Fix multiple handler callbacks in YamlDriver #515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @schmittjoh Would be nice to see this merged, the fix is simple and obvious. If the new tests need some more work, I'll be happy to improve them. The test failures seem unrelated and are probably fixed by #511 in any case. |
mpajunen
force-pushed
the
yaml-driver-handler-callbacks
branch
from
0388346 to
b044dd0
Compare
|
Rebased, tests are now green as well. |
| @@ -204,8 +204,8 @@ protected function loadMetadataFromFile(\ReflectionClass $class, $file) | |||
|
|
|||
| if (isset($config['handler_callbacks'])) { | |||
| foreach ($config['handler_callbacks'] as $direction => $formats) { | |||
| $direction = GraphNavigator::parseDirection($direction); | |||
There was a problem hiding this comment.
as this store a different thing, it would be even better to use a different variable name instead of overwriting the variable
There was a problem hiding this comment.
Loop variable name changed to $directionName.
mpajunen
force-pushed
the
yaml-driver-handler-callbacks
branch
from
b044dd0 to
dcaf30a
Compare
|
will be part of v1.3, tnx |
|
Nice to see this merged finally, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using handler callbacks for multiple formats caused errors in
YamlDriverbecause thedirectionkey was parsed multiple times. Nowdirectionkey is only parsed once (per direction).A basic test case for handler callbacks is included for all configuration formats.