Skip to content

Fix tests #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix tests #511

wants to merge 1 commit into from

Conversation

soullivaneuh
Copy link
Contributor

As I said on #510 (comment), there is some failing tests on master.

This PR fixes them.

BTW, you should configure Travis with the repository to prevent it on the future.

@stof
Copy link
Contributor

stof commented Oct 20, 2015

Travis is running. It is simply not reporting the commit status because of an outdated token. See #495

@soullivaneuh
Copy link
Contributor Author

It is simply not reporting the commit

Yeah, this is what I want to say. ;-)

@TiS
Copy link

TiS commented Oct 20, 2015

As for fixing doctype tests, I have referenced this in #508 . I thought it was deliberate that doctypes work using full <!DOCTYPE string (to maintain backwards compatibility), so "corrected" the function instead of tests.

@soullivaneuh
Copy link
Contributor Author

Nice @TiS. Ping me when your PR will be merged, I'll update mine. 👍

@TiS
Copy link

TiS commented Oct 20, 2015

I'm not sure, if my solution is better than yours ;) But if project owner decides so, I'll let you know.

@soullivaneuh
Copy link
Contributor Author

ping @schmittjoh

@localheinz
Copy link
Contributor

@schmittjoh

Can we merge this to make the build pass?

Also see #526.

@goetas
Copy link
Collaborator

goetas commented May 9, 2016

this is probably outdated now

@goetas
Copy link
Collaborator

goetas commented Aug 3, 2016

Closing, tests are already green. If some features are missing, please re open a new PR

@goetas goetas closed this Aug 3, 2016
@localheinz
Copy link
Contributor

@goetas

It's probably outdated because nobody has taken care of it.

@goetas
Copy link
Collaborator

goetas commented Aug 3, 2016

@localheinz , i started right today as maintainer of this project, hope in the future PRs will have a shorter feedback loop

@localheinz
Copy link
Contributor

@goetas

👍

@soullivaneuh soullivaneuh deleted the tests-fix branch June 26, 2017 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants