-
-
Notifications
You must be signed in to change notification settings - Fork 586
Fix tests #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests #511
Conversation
Travis is running. It is simply not reporting the commit status because of an outdated token. See #495 |
Yeah, this is what I want to say. ;-) |
As for fixing doctype tests, I have referenced this in #508 . I thought it was deliberate that doctypes work using full <!DOCTYPE string (to maintain backwards compatibility), so "corrected" the function instead of tests. |
Nice @TiS. Ping me when your PR will be merged, I'll update mine. 👍 |
I'm not sure, if my solution is better than yours ;) But if project owner decides so, I'll let you know. |
ping @schmittjoh |
Can we merge this to make the build pass? Also see #526. |
this is probably outdated now |
Closing, tests are already green. If some features are missing, please re open a new PR |
It's probably outdated because nobody has taken care of it. |
@localheinz , i started right today as maintainer of this project, hope in the future PRs will have a shorter feedback loop |
👍 |
As I said on #510 (comment), there is some failing tests on master.
This PR fixes them.
BTW, you should configure Travis with the repository to prevent it on the future.