Skip to content

Discriminator Groups #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Discriminator Groups #567

wants to merge 8 commits into from

Conversation

maennchen
Copy link

@schmittjoh
Copy link
Owner

Could you add tests?

@maennchen
Copy link
Author

Yes. Could you by any chance merge the PR #511 that my tests could have a chance to pass?

@maennchen
Copy link
Author

@schmittjoh Tests are done.

@maennchen
Copy link
Author

@schmittjoh: I'm going to apply it on my own fork since you're obviously not interested in maintaining this lib anymore.

@maennchen maennchen closed this Apr 25, 2016
@maennchen maennchen deleted the discriminator_groups_rebased branch April 25, 2016 12:41
@wins1908
Copy link

wins1908 commented May 4, 2016

@maennchen Could you add your branch again? I need your branch too
@schmittjoh Could you accept @maennchen merge request?

@maennchen
Copy link
Author

I waited long enough. Feel free to merge jms-serializer/serializer back into the official repo.

@maennchen
Copy link
Author

You can install the fork by running this command:

composer require "jms-serializer/serializer"

It will replace the original lib.

@schmittjoh
Copy link
Owner

@maennchen, sorry for the wait, would you mind re-basing the discriminator commit and adjusting the serialize/unserialize method so that it is BC by either throwing an exception or setting a default value? It looks good otherwise.

@maennchen maennchen mentioned this pull request May 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants