-
-
Notifications
You must be signed in to change notification settings - Fork 586
Discriminator Groups #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discriminator Groups #567
Conversation
Could you add tests? |
Yes. Could you by any chance merge the PR #511 that my tests could have a chance to pass? |
@schmittjoh Tests are done. |
@schmittjoh: I'm going to apply it on my own fork since you're obviously not interested in maintaining this lib anymore. |
@maennchen Could you add your branch again? I need your branch too |
I waited long enough. Feel free to merge jms-serializer/serializer back into the official repo. |
You can install the fork by running this command: composer require "jms-serializer/serializer" It will replace the original lib. |
@maennchen, sorry for the wait, would you mind re-basing the discriminator commit and adjusting the serialize/unserialize method so that it is BC by either throwing an exception or setting a default value? It looks good otherwise. |
Fix for Issue schmittjoh/JMSSerializerBundle#506