Skip to content

ESLint: Fix flat config setup #31192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

ESLint: Fix flat config setup #31192

merged 2 commits into from
Apr 22, 2025

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Apr 22, 2025

Closes #

What I did

For ESLint flat configs that use array, the storybook plugin should be spread and it wasn't. This PR fixes that

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

This PR modifies the ESLint flat config setup in Storybook to properly spread plugin configurations in array-based setups.

  • Fixed configureFlatConfig function in code/core/src/cli/eslintPlugin.ts to use t.spreadElement() when adding Storybook configs to arrays
  • Updated test cases in eslintPlugin.test.ts to verify proper spreading behavior with various config types (JS, TS, const declarations)
  • Ensures compatibility with TypeScript-specific configurations like satisfies and as type assertions
  • Maintains backward compatibility with existing ESLint configurations while fixing array spreading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Apr 22, 2025

View your CI Pipeline Execution ↗ for commit 64cbdf9.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 37s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-22 15:01:33 UTC

@yannbf yannbf merged commit 9058caf into next Apr 22, 2025
54 of 57 checks passed
@yannbf yannbf deleted the yann/fix-flat-config-setup branch April 22, 2025 15:17
@github-actions github-actions bot mentioned this pull request Apr 22, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants