Add a thread-safe implementation of Process.currentDirectoryURL #4981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
jakepetroules
force-pushed
the
process-currentdir-threadsafe
branch
from
7d52c8b to
a00fe20
Compare
|
@swift-ci please test |
|
@iCharlesHu can you review please? |
iCharlesHu
reviewed
Sep 9, 2024
jakepetroules
force-pushed
the
process-currentdir-threadsafe
branch
from
a00fe20 to
84ffdeb
Compare
|
@swift-ci please test |
|
@swift-ci test windows |
iCharlesHu
approved these changes
Sep 24, 2024
posix_spawn_file_actions_addchdir_np is the official way to set the working directory of a spawned process and is supported on both macOS and glibc (Linux, etc.). This makes Process.currentDirectoryURL thread-safe, as the current approach will result in the working directory being nondeterministically assigned when spawning processes across multiple threads, using different working directories.
jakepetroules
force-pushed
the
process-currentdir-threadsafe
branch
from
84ffdeb to
001fb5c
Compare
|
@swift-ci please test |
jakepetroules
added a commit
that referenced
this pull request
Sep 28, 2024
Swift still needs to support Amazon Linux 2 until it EoLs in mid-2025. So restore the thread-unsafe fallback for systems with glibc older than version 2.29, which was removed in #4981.
jakepetroules
added a commit
that referenced
this pull request
Sep 29, 2024
Swift still needs to support Amazon Linux 2 until it EoLs in mid-2025. So restore the thread-unsafe fallback for systems with glibc older than version 2.29, which was removed in #4981.
jakepetroules
added a commit
that referenced
this pull request
Sep 30, 2024
Swift still needs to support Amazon Linux 2 until it EoLs in mid-2025. So restore the thread-unsafe fallback for systems with glibc older than version 2.29, which was removed in #4981.
jakepetroules
added a commit
that referenced
this pull request
Oct 2, 2024
Swift still needs to support Amazon Linux 2 until it EoLs in mid-2025. So restore the thread-unsafe fallback for systems with glibc older than version 2.29, which was removed in #4981.
jakepetroules
added a commit
that referenced
this pull request
Oct 2, 2024
Swift still needs to support Amazon Linux 2 until it EoLs in mid-2025. So restore the thread-unsafe fallback for systems with glibc older than version 2.29, which was removed in #4981.
parkera
pushed a commit
that referenced
this pull request
Oct 10, 2024
…RL (#5095) * Add a thread-safe implementation of Process.currentDirectoryURL posix_spawn_file_actions_addchdir_np is the official way to set the working directory of a spawned process and is supported on both macOS and glibc (Linux, etc.). This makes Process.currentDirectoryURL thread-safe, as the current approach will result in the working directory being nondeterministically assigned when spawning processes across multiple threads, using different working directories. * Restore thread-unsafe fallback for setting the Process working directory Swift still needs to support Amazon Linux 2 until it EoLs in mid-2025. So restore the thread-unsafe fallback for systems with glibc older than version 2.29, which was removed in #4981.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
posix_spawn_file_actions_addchdir_np is the official way to set the working directory of a spawned process and is supported on both macOS and glibc (Linux, etc.). This makes Process.currentDirectoryURL thread-safe, as the current approach will result in the working directory being nondeterministically assigned when spawning processes across multiple threads, using different working directories.