Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore thread-unsafe fallback for setting the Process working directory #5090

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

jakepetroules
Copy link
Contributor

Swift still needs to support Amazon Linux 2 until it EoLs in mid-2025. So restore the thread-unsafe fallback for systems with glibc older than version 2.29, which was removed in #4981.

@iCharlesHu
Copy link
Contributor

/home/build-user/swift-corelibs-foundation/Sources/Foundation/Process.swift:974:60: error: cannot find 'previousDirectoryPath' in scope
 972 |                 // Reset the previous working directory path.
 973 |                 let fileManager = FileManager()
 974 |                 _ = fileManager.changeCurrentDirectoryPath(previousDirectoryPath)
     |                                                            `- error: cannot find 'previousDirectoryPath' in scope
 975 |             }
 976 |         }

Looks like the failure is related

Swift still needs to support Amazon Linux 2 until it EoLs in mid-2025. So restore the thread-unsafe fallback for systems with glibc older than version 2.29, which was removed in #4981.
@jakepetroules jakepetroules force-pushed the process-currentdir-threadsafe branch from bd94bcd to 4623e8e Compare September 30, 2024 18:01
@jakepetroules jakepetroules merged commit 7b5cd12 into main Oct 1, 2024
2 checks passed
@jakepetroules jakepetroules deleted the process-currentdir-threadsafe branch October 1, 2024 06:06
@iCharlesHu
Copy link
Contributor

@swift-ci please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants