[FrameworkBundle] append instead of replacing potentially non-existent named-arguments

[xabbuh]

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	Fix #52998 (comment)
License	MIT

[nicolas-grekas]

Can't we stop using named args at all?
So those args are already wired in the default config files?

[xabbuh]

Can't we stop using named args at all?
So those args are already wired in the default config files?

That's what we do now. Or do I misunderstand what you are asking for?

[rdavaillaud]

The problem is that the bridges are wired via a factory that is declared via an abstract factory.

see

symfony/src/Symfony/Bundle/FrameworkBundle/Resources/config/notifier_transports.php

Line 151 in 317c67b

->set('notifier.transport_factory.fake-sms', FakeSmsTransportFactory::class)

As far as I have tested, if we remove the HttpClient and Dispatcher from the definition, they will not be injected in the constructor.

[xabbuh]

I mean we revert the framework extension changes made in #52998 which were not necessary because of the notifier.transport_factory.abstract definition: https://github.com/symfony/symfony/blob/5.4/src/Symfony/Bundle/FrameworkBundle/Resources/config/notifier_transports.php#L90-L92

[rdavaillaud]

If we revert the changes, the DI will generate this code (at least in 6.3):

class getNotifier_TransportFactory_FakesmsService extends App_KernelDevDebugContainer
{
    /**
     * Gets the private 'notifier.transport_factory.fake-sms' shared service.
     *
     * @return \Symfony\Component\Notifier\Bridge\FakeSms\FakeSmsTransportFactory
     */
    public static function do($container, $lazyLoad = true)
    {
        include_once \dirname(__DIR__, 4).'/vendor/symfony/notifier/Transport/TransportFactoryInterface.php';
        include_once \dirname(__DIR__, 4).'/vendor/symfony/notifier/Transport/AbstractTransportFactory.php';
        include_once \dirname(__DIR__, 4).'/vendor/symfony/fake-sms-notifier/FakeSmsTransportFactory.php';

        return new \Symfony\Component\Notifier\Bridge\FakeSms\FakeSmsTransportFactory(($container->privates['mailer.mailer'] ?? self::getMailer_MailerService($container)), ($container->privates['monolog.logger'] ?? self::getMonolog_LoggerService($container)));
    }
}

The HttpClient and EventDispatcher are replaced, not injected.

[rdavaillaud]

If we revert the FrameworkBundle, we must also change the signatures of the bridges Fake* constructor to put Mailer and Logger at the end.

[rdavaillaud]

@xabbuh your last change seems to work with the old bridge, and the modified one. 👍

[nicolas-grekas]

Thank you @xabbuh.

[xabbuh]

@rdavaillaud Thank you for testing it!