Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow setting custom karpenter IRSA policy name #2438

Closed
wants to merge 1 commit into from

Conversation

patrickleet
Copy link
Contributor

@patrickleet patrickleet commented Feb 1, 2023

Description

allow setting custom IRSA policy name separately from custom role name.

You can use irsa_name currently to set them both to the same thing, but there is no way to give them each custom names.

Motivation and Context

My organization has requirements around role and policy names. The module only lets you set a role name currently, and uses that as the policy name. I need to be able to set a policy name, and a role name, and not to the same thing.

Breaking Changes

No. Made it backwards compatible.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

I ran it locally on a project with all combinations of providing names or not.

@patrickleet patrickleet changed the title feat[karpenter]: allow setting custom IRSA policy name feat(karpenter): allow setting custom IRSA policy name Feb 1, 2023
@patrickleet patrickleet changed the title feat(karpenter): allow setting custom IRSA policy name feat: allow setting custom IRSA policy name Feb 1, 2023
@patrickleet patrickleet changed the title feat: allow setting custom IRSA policy name feat: allow setting custom karpenter IRSA policy name Feb 1, 2023
@patrickleet patrickleet changed the title feat: allow setting custom karpenter IRSA policy name feat: Allow setting custom karpenter IRSA policy name Feb 1, 2023
@bryantbiggs
Copy link
Member

you can specify the name you want to use today with irsa_name, no changes are required

@bryantbiggs bryantbiggs closed this Feb 7, 2023
@patrickleet
Copy link
Contributor Author

no you can't

@patrickleet
Copy link
Contributor Author

you can only name the policy AND the role the same thing - you can not name them differently, which is my requirement

@patrickleet
Copy link
Contributor Author

@bryantbiggs can you please re-open and merge this - you are incorrect about no changes being required. Thanks.

@patrickleet
Copy link
Contributor Author

@bryantbiggs can we add this functionality?

@bryantbiggs
Copy link
Member

I suppose we can add this - however, its not giving me the option to re-open the PR (button is grayed out)

@patrickleet
Copy link
Contributor Author

I'll recreate it - thanks

@patrickleet
Copy link
Contributor Author

@bryantbiggs rebased and re-opened here: #2480

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants