-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow setting custom karpenter IRSA policy name #2438
Conversation
you can specify the name you want to use today with |
no you can't |
you can only name the policy AND the role the same thing - you can not name them differently, which is my requirement |
@bryantbiggs can you please re-open and merge this - you are incorrect about no changes being required. Thanks. |
@bryantbiggs can we add this functionality? |
I suppose we can add this - however, its not giving me the option to re-open the PR (button is grayed out) |
I'll recreate it - thanks |
@bryantbiggs rebased and re-opened here: #2480 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
allow setting custom IRSA policy name separately from custom role name.
You can use
irsa_name
currently to set them both to the same thing, but there is no way to give them each custom names.Motivation and Context
My organization has requirements around role and policy names. The module only lets you set a role name currently, and uses that as the policy name. I need to be able to set a policy name, and a role name, and not to the same thing.
Breaking Changes
No. Made it backwards compatible.
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull requestI ran it locally on a project with all combinations of providing names or not.