-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(no-await-sync-events): add to DOM, Angular & React configs by default #667
feat(no-await-sync-events): add to DOM, Angular & React configs by default #667
Conversation
should user event be removed from this rule since all methods are async (so there are no sync methods to incorrectly await)? I think the rule as it is may create false positives/negatives in user event v14? |
That's right. I think this was mentioned in another issue. Let me create a ticket for it in the v6 project. |
Issue for updating |
Makes sense to me. |
…fault BREAKING CHANGE: `no-await-sync-events` is now enabled by default in the DOM, Angular & React configs
b41a6d2
to
74658f4
Compare
I guess you mean rules from TypeScript ESLint? If your codebase is written in TS, definitely the sync/async rules can be skipped. But if your codebase is written in JS, then those rules make sense. |
🎉 This PR is included in version 6.0.0-alpha.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
BREAKING CHANGE:
no-await-sync-events
is now enabled by default in the DOM, Angular & React configsCloses #619