-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(no-await-sync-events): stop reporting user-event
by default
#803
fix(no-await-sync-events): stop reporting user-event
by default
#803
Conversation
…c-await-events-and-no-await-sync-events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should release this in a major release btw as this is breaking behavior for this specific rule and people need to adjust their config if they want the current released functionality (for instance when only enabling this specific rule)
Co-authored-by: Michaël De Boey <[email protected]> Signed-off-by: Mario Beltrán <[email protected]>
Not really. In our semantic version policy, we specify that a bug fix in a rule that results in eslint-plugin-testing-library reporting fewer errors will be a patch release. The rule was reporting both fire-event and user-event. The change done here is to report only fire-event by default. The changes in the presets were needed to reflect the new default change correctly. However, the actual config of the rule and the way it reports the errors are the same. I get the point of your comment, tho. A change in the number of errors reported could potentially be a breaking change. That's why we defined the semver policy, inspired by ESLint semver policity itself, so users know what to expect. |
🎉 This PR is included in version 6.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Checks
Changes
user-event
methods by default, assuming v14 is the standard now.Context
Fixes #801
Fixes #669