Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure with php 7.2 #322

Closed
hemberger opened this issue Dec 28, 2017 · 4 comments
Closed

Failure with php 7.2 #322

hemberger opened this issue Dec 28, 2017 · 4 comments

Comments

@hemberger
Copy link

hemberger commented Dec 28, 2017 •
edited
Loading

Using the php:7 docker image (which currently uses PHP_VERSION=7.2.0), I get the following error when trying to run phpdox:

PHP Version: 7.2.0 (Linux)
PHPDox Version: 0.10.1
ErrorException: E_WARNING 
Location: /root/.composer/vendor/theseer/phpdox/src/shared/FileInfoCollection.php (Line 67)

count(): Parameter must be an array or an object that implements Countable

#0 /root/.composer/vendor/theseer/phpdox/src/shared/FileInfoCollection.php(67): count()
#1 /root/.composer/vendor/theseer/phpdox/src/shared/FileInfoCollection.php(53): TheSeer\phpDox\FileInfoCollection->count()
#2 /root/.composer/vendor/theseer/phpdox/src/bootstrap/Bootstrap.php(56): TheSeer\phpDox\FileInfoCollection->valid()
#3 /root/.composer/vendor/theseer/phpdox/src/CLI.php(130): TheSeer\phpDox\Bootstrap->load()
#4 /root/.composer/vendor/theseer/phpdox/phpdox(79): TheSeer\phpDox\CLI->run()

Last success I had was with PHP_VERSION=7.1.12 (the php:7.1 docker image).

I assume this will be fixed by #317 ?
@hemberger
Copy link
Author

I think I may have overlooked that this was already fixed by e521bc9. If we are just waiting on the version installed by Composer to be bumped, please close this, and my apologies for the duplication.

@hemberger hemberger mentioned this issue Dec 28, 2017
Merged
@theseer
Copy link
Owner

theseer commented Dec 28, 2017

I indeed should bump the version to release the fix. Thank you for the reminder.

@dehrk
Copy link

dehrk commented Jan 4, 2018

Any idea when this bug will be fixed? Thanks.

@theseer
Copy link
Owner

theseer commented Jan 9, 2018

Fix is part of the 0.11 release.

@theseer theseer closed this as completed Jan 9, 2018
hemberger added a commit to hemberger/smr that referenced this issue Mar 9, 2018
@hemberger
docs/Dockerfile: update to PHP 7.2
8569ef5 
* PHPDox was fixed to correctly support PHP 7.2 in the v0.11 release.
  See theseer/phpdox#322.

* Clarify that we're using the CLI image variant (note that 7.2 is
  the same as 7.2-cli).

NOTE: We would like to use 7.2-cli-alpine for the builder image,
even though it has no effect on the final image, since it affects
the intermediate images for local building. However, PHPDox has
problems with the alpine image (likely due to the poor support
of `iconv`).
@hemberger hemberger mentioned this issue Mar 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@theseer @hemberger @dehrk