Fix #315: Convert null to array for count()

[swmarc]

count(): Parameter must be an array or an object
that implements Countable

Signed-off-by: Marcel Saegebarth [email protected]

[theseer]

Thank you for looking into this and providing a possible fix.

Instead of doing a type cast to fix the count call, I think the root cause is that I didn't initialize the property as an array. So the simple fix would be to replace private $data; by private $data = [];

Mind to change the fix accordingly? I'll try to merge it tomorrow.

[swmarc]

That was my first thought too, but it could be that returning NULL (no method actually implement that) is may expected instead an empty array.
For instance, key() could return NULL because the property isn't initialized also.

[theseer]

So there are two bugs ;)

Returning NULL is a bad idea in pretty much any case. I'll try to look into it over the weekend.

Thanks for pointing it out!