drop Python 2.6 and 3.3 support #689

gaborbernat · 2017-11-29T13:23:07Z

Resolves #679.

Took the opportunity to also update our documentation, so we no longer refer to Python <2.7 or Python <=3.3 in there.

nicoddemus · 2017-11-29T13:27:54Z

setup.py

@@ -59,21 +51,20 @@ def main():
        author_email='[email protected]',
        packages=['tox'],
        entry_points={'console_scripts': 'tox=tox:cmdline\ntox-quickstart=tox._quickstart:main'},
+        python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*',


nicoddemus · 2017-11-29T13:29:01Z

changelog/679.feature.rst

@@ -0,0 +1,2 @@
+drop Pyhton ``2.6`` and ``3.3`` support: ``setuptools`` dropped supporting these, and as we depend on it we'll follow
+up with doing the same (use ``tox <= 2.9.1`` if you still need this support) - by @gaborbernat


You can mention that a recent enough pip (>=9) should automatically install < 2.9 on Python 2.6 and Python 3.3.

nicoddemus

Awesome, I made some minor comments 👍

nicoddemus · 2017-11-29T14:33:43Z

doc/example/nose.rst

@@ -25,7 +25,7 @@ and the following ``tox.ini`` content:

 you can invoke ``tox`` in the directory where your ``tox.ini`` resides.
 ``tox`` will sdist-package your project create two virtualenv environments
-with the ``python2.6`` and ``python2.5`` interpreters, respectively, and will
+with the ``python3.6`` and ``python2.5`` interpreters, respectively, and will


Probably worth updating python2.5 to a more modern version as well

nicoddemus · 2017-11-29T14:34:34Z

doc/index.rst

@@ -68,7 +68,7 @@ Current features
 * uses pip_ and setuptools_ by default.  Support for configuring the installer command
  through :confval:`install_command=ARGV`.

-* **cross-Python compatible**: CPython-2.6, 2.7, 3.2 and higher,
+* **cross-Python compatible**: CPython-2.7, 3.3 and higher,


*3.4 and higher

nicoddemus · 2017-11-29T14:35:44Z

setup.py

    install_requires = ['py>=1.4.17', 'pluggy>=0.3.0,<1.0', 'six']
    extras_require = {}
    if has_environment_marker_support():
-        extras_require[':python_version=="2.6"'] = ['argparse']
-        extras_require[':python_version=="3.2"'] = virtualenv_capped
        extras_require[':python_version!="3.2"'] = virtualenv_open


This section can be removed and virtualenv_open can be added directly to install_requires above.

asottile · 2017-11-29T17:16:05Z

looks like we're hitting travis-ci/travis-ci#8363 now

asottile · 2017-11-29T17:28:17Z

tox.ini

@@ -107,5 +96,5 @@ exclude_lines = if __name__ == ["']__main__["']:
 addopts = -rsxX
 rsyncdirs = tests tox
 looponfailroots = tox tests
-norecursedirs = .hg .tox
+norecursedirs = .hg {toxworkdir}


is this working as intended? I kind of doubt that pytest is going to properly substitute toxworkdir

asottile · 2017-11-29T17:29:10Z

tox.ini

 [testenv:X]
 description = print the positional arguments passed in with echo
 commands = echo {posargs}

 [testenv:coverage]
 description = [run locally after tests]: combine coverage data and create reports
 skip_install = True
+changedir={toxworkdir}


this is unrelated to the changes here (and it seems breaking windows) -- did you accidentally commit this over another WIP branch?

no accident, will take a look

asottile · 2017-11-29T17:32:19Z

changelog/679.feature.rst

@@ -0,0 +1,2 @@
+drop Pyhton ``2.6`` and ``3.3`` support: ``setuptools`` dropped supporting these, and as we depend on it we'll follow


asottile · 2017-11-29T17:32:59Z

doc/config-v2.rst

@@ -195,7 +195,7 @@ Default settings related to environments names/variants
 tox comes with predefined settings for certain variants, namely:

 * ``{easy,pip}`` use easy_install or pip respectively
-* ``{py24,py25,py26,py27,py31,py32,py33,py34,pypy19]`` use the respective
+* ``{py27,py36,py35,py34,pypy19]`` use the respective


nit: I'd expect these to be in increasing order instead of decreasing

same for the rest of the docs -- we should consistently:

mention pythonx.x, pythony.y in increasing order

list tox environments in increasing order

I understand this makes your diff less minimal, but it makes the docs read better :)

asottile · 2017-11-29T17:35:23Z

doc/example/result.rst

@@ -40,7 +40,7 @@ This will create a json-formatted result file using this schema:
      "platform": "linux2",
      "installpkg": {
        "basename": "tox-1.6.0.dev1.zip",
-        "sha256": "b6982dde5789a167c4c35af0d34ef72176d0575955f5331ad04aee9f23af4326",
+        "sha356": "b6982dde5789a167c4c35af0d34ef72176d0575955f5331ad04aee9f23af4336",


woops, nice sed :D

asottile · 2017-11-29T17:36:59Z

tests/test_config.py

@@ -1388,7 +1388,7 @@ def test_factors(self, newconfig):
        conf = newconfig([], inisource)
        configs = conf.envconfigs
        assert [dep.name for dep in configs['a-x'].deps] == \
-            ["dep-all", "dep-a", "dep-x"]
+               ["dep-all", "dep-a", "dep-x"]


orthogonal to this change?

asottile

mostly looks good, fix the two typos and the ordering and

asottile · 2017-12-01T00:02:54Z

doc/config-v2.rst

@@ -253,13 +253,13 @@ Another `tox.ini
 has 233 lines and runs tests against multiple Postgres and Mysql
 engines.  It also performs backend-specific test commands, passing
 different command line options to the test script.  With the new tox-1.X
-we not only can do the same with 32 non-repetive configuration lines but
+we not only can do the same with 35 non-repetive configuration lines but


I don't think this one was supposed to change

asottile · 2017-12-01T00:03:39Z

doc/example/general.rst

@@ -74,7 +74,7 @@ which will make the sphinx tests part of your test run.
 Selecting one or more environments to run tests against
 --------------------------------------------------------

-Using the ``-e ENV[,ENV2,...]``  option you explicitly list
+Using the ``-e ENV[,ENV36,...]``  option you explicitly list


this one looks like a mistake too

this one I think is fine 👍

I don't or I wouldn't have pointed it out. This is a listing of environments and yes while most of them are usually python environments this is documenting the command line.

asottile · 2017-12-01T00:04:01Z

doc/example/nose.rst

@@ -25,7 +25,7 @@ and the following ``tox.ini`` content:

 you can invoke ``tox`` in the directory where your ``tox.ini`` resides.
 ``tox`` will sdist-package your project create two virtualenv environments
-with the ``python2.6`` and ``python2.5`` interpreters, respectively, and will
+with the ``python3.6`` and ``python2.7`` interpreters, respectively, and will


ordering here

asottile · 2017-12-01T00:04:29Z

doc/example/unittest.rst

@@ -76,8 +76,8 @@ the checkout has a tox.ini_ that looks like this:

 mock uses unittest2_ to run the tests. Invoking ``tox`` starts test
 discovery by executing the ``unit2 discover``
-commands on Python 2.4, 2.5, 2.6 and 2.7 respectively.  Against
-Python2.6 and Python2.7 it will additionally run sphinx-mediated
+commands on Python 2.4, 2.5, 3.6 and 2.7 respectively.  Against


ordering here, also 2.4 and 2.5

asottile · 2017-12-01T00:04:34Z

doc/example/unittest.rst

@@ -50,13 +50,13 @@ the checkout has a tox.ini_ that looks like this:
 .. code-block:: ini

    [tox]
-    envlist = py24,py25,py26,py27
+    envlist = py34,py35,py36,py27


ordering here

asottile · 2017-12-01T00:04:39Z

doc/example/unittest.rst

@@ -19,7 +19,7 @@ and add the following ``tox.ini`` to it:
 .. code-block:: ini

    [tox]
-    envlist = py25,py26,py27
+    envlist = py35,py36,py27


ordering here

asottile · 2017-12-01T00:04:57Z

doc/index.rst


    tox

-and watch things happening (you must have python2.6 and python2.7 installed in your
+and watch things happening (you must have python3.6 and python2.7 installed in your


ordering here

asottile · 2017-12-01T00:05:40Z

tox/interpreters.py

@@ -17,7 +17,7 @@ def __init__(self, hook):

    def get_executable(self, envconfig):
        """ return path object to the executable for the given
-        name (e.g. python2.6, python2.7, python etc.)
+        name (e.g. python3.6, python2.7, python etc.)


ordering here

codecov · 2017-12-01T03:45:56Z

Codecov Report

Merging #689 into master will decrease coverage by 1.31%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #689      +/-   ##
==========================================
- Coverage   90.77%   89.45%   -1.32%     
==========================================
  Files          11       11              
  Lines        2373     2371       -2     
  Branches      402      401       -1     
==========================================
- Hits         2154     2121      -33     
- Misses        144      175      +31     
  Partials       75       75

Impacted Files	Coverage Δ
tox/interpreters.py	`59.37% <ø> (-17.97%)`	⬇️
tox/_pytestplugin.py	`89.87% <ø> (-0.09%)`	⬇️
tox/_quickstart.py	`77.62% <100%> (ø)`	⬆️
tox/config.py	`94.82% <100%> (-0.26%)`	⬇️
tox/venv.py	`92.52% <0%> (-1.25%)`	⬇️
tox/session.py	`91.63% <0%> (-0.37%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95c9b73...d5deac5. Read the comment docs.

gaborbernat self-assigned this Nov 29, 2017

gaborbernat requested review from hpk42, RonnyPfannschmidt, obestwalter and asottile November 29, 2017 13:23

nicoddemus reviewed Nov 29, 2017

View reviewed changes

nicoddemus approved these changes Nov 29, 2017

View reviewed changes

drop Python 2.6 and 3.3 support

e228b00

asottile reviewed Nov 29, 2017

View reviewed changes

PR review

00e7768

asottile approved these changes Nov 30, 2017

View reviewed changes

gaborbernat added 2 commits November 30, 2017 23:02

fix Travis Python 3.5 issue

291c7b8

fix coverage collection bug

dbd6c75

asottile approved these changes Dec 1, 2017

View reviewed changes

PR feedback

d5deac5

gaborbernat merged commit 0fb3b7c into tox-dev:master Dec 1, 2017

asottile mentioned this pull request Dec 30, 2017

Regain Python 2.6 support python-distro/distro#206

Closed

mpeteuil mentioned this pull request May 21, 2018

Pass reader error messages along ryanhiebert/backports.csv#28

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

drop Python 2.6 and 3.3 support #689

drop Python 2.6 and 3.3 support #689

gaborbernat commented Nov 29, 2017

nicoddemus Nov 29, 2017

nicoddemus Nov 29, 2017

nicoddemus left a comment

nicoddemus Nov 29, 2017

nicoddemus Nov 29, 2017

nicoddemus Nov 29, 2017

asottile commented Nov 29, 2017

asottile Nov 29, 2017

asottile Nov 29, 2017

gaborbernat Nov 29, 2017

asottile Nov 29, 2017

asottile Nov 29, 2017

asottile Nov 29, 2017

asottile Nov 29, 2017

asottile Nov 29, 2017

asottile left a comment

asottile Dec 1, 2017

asottile Dec 1, 2017

gaborbernat Dec 1, 2017

asottile Dec 1, 2017

asottile Dec 1, 2017

asottile Dec 1, 2017

asottile Dec 1, 2017

asottile Dec 1, 2017

asottile Dec 1, 2017

asottile Dec 1, 2017

codecov bot commented Dec 1, 2017 •

edited

Loading

		@@ -0,0 +1,2 @@
		drop Pyhton ``2.6`` and ``3.3`` support: ``setuptools`` dropped supporting these, and as we depend on it we'll follow
		up with doing the same (use ``tox <= 2.9.1`` if you still need this support) - by @gaborbernat

drop Python 2.6 and 3.3 support #689

drop Python 2.6 and 3.3 support #689

Conversation

gaborbernat commented Nov 29, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicoddemus left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asottile commented Nov 29, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asottile left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Dec 1, 2017 • edited Loading

Codecov Report

codecov bot commented Dec 1, 2017 •

edited

Loading