-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop Python 2.6 and 3.3 support #689
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,5 +22,3 @@ htmlcov | |
.idea | ||
.eggs/ | ||
py27/ | ||
|
||
.coverage.* |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
drop Python ``2.6`` and ``3.3`` support: ``setuptools`` dropped supporting these, and as we depend on it we'll follow | ||
up with doing the same (use ``tox <= 2.9.1`` if you still need this support) - by @gaborbernat | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,7 +62,7 @@ namely these goals: | |
Example: Generating and selecting variants | ||
---------------------------------------------- | ||
|
||
Suppose you want to test your package against python2.6, python2.7 and on the | ||
Suppose you want to test your package against python3.6, python2.7 and on the | ||
windows and linux platforms. Today you would have to | ||
write down 2*2 = 4 ``[testenv:*]`` sections and then instruct | ||
tox to run a specific list of environments on each platform. | ||
|
@@ -71,29 +71,29 @@ With tox-1.X you can directlys specify combinations:: | |
|
||
# combination syntax gives 2 * 2 = 4 testenv names | ||
# | ||
envlist = {py26,py27}-{win,linux} | ||
envlist = {py27,py36}-{win,linux} | ||
|
||
[testenv] | ||
deps = pytest | ||
platform = | ||
win: windows | ||
linux: linux | ||
basepython = | ||
py26: python2.6 | ||
py27: python2.7 | ||
py36: python3.6 | ||
commands = pytest | ||
|
||
Let's go through this step by step:: | ||
|
||
envlist = {py26,py27}-{windows,linux} | ||
envlist = {py27,py36}-{windows,linux} | ||
|
||
This is bash-style syntax and will create ``2*2=4`` environment names | ||
like this:: | ||
|
||
py26-windows | ||
py26-linux | ||
py27-windows | ||
py27-linux | ||
py36-windows | ||
py36-linux | ||
|
||
Our ``[testenv]`` uses a new templating style for the ``platform`` definition:: | ||
|
||
|
@@ -110,10 +110,10 @@ The next configuration item in the ``testenv`` section deals with | |
the python interpreter:: | ||
|
||
basepython = | ||
py26: python2.6 | ||
py27: python2.7 | ||
py36: python3.6 | ||
|
||
This defines a python executable, depending on if ``py26`` or ``py27`` | ||
This defines a python executable, depending on if ``py36`` or ``py27`` | ||
appears in the environment name. | ||
|
||
The last config item is simply the invocation of the test runner:: | ||
|
@@ -128,7 +128,7 @@ Nothing special here :) | |
settings, so the above ini-file can be further reduced:: | ||
|
||
[tox] | ||
envlist = {py26,py27}-{win,linux} | ||
envlist = {py27,py36}-{win,linux} | ||
|
||
[testenv] | ||
deps = pytest | ||
|
@@ -185,7 +185,7 @@ If you want to have your package installed with both easy_install | |
and pip, you can list them in your envlist likes this:: | ||
|
||
[tox] | ||
envlist = py[26,27,32]-django[13,14]-[easy,pip] | ||
envlist = py[27,35,36]-django[13,14]-[easy,pip] | ||
|
||
If no installer is specified, ``pip`` will be used. | ||
|
||
|
@@ -195,7 +195,7 @@ Default settings related to environments names/variants | |
tox comes with predefined settings for certain variants, namely: | ||
|
||
* ``{easy,pip}`` use easy_install or pip respectively | ||
* ``{py24,py25,py26,py27,py31,py32,py33,py34,pypy19]`` use the respective | ||
* ``{py27,py34,py35,py36,pypy19]`` use the respective | ||
pythonNN or PyPy interpreter | ||
* ``{win32,linux,darwin}`` defines the according ``platform``. | ||
|
||
|
@@ -217,11 +217,11 @@ Transforming the examples: django-rest | |
|
||
The original `django-rest-framework tox.ini | ||
<https://github.com/encode/django-rest-framework/blob/b001a146d73348af18cfc4c943d87f2f389349c9/tox.ini>`_ | ||
file has 159 lines and a lot of repetition, the new one would +have 20 | ||
file has 159 lines and a lot of repetition, the new one would have ``20+`` | ||
lines and almost no repetition:: | ||
|
||
[tox] | ||
envlist = {py25,py26,py27}-{django12,django13}{,-example} | ||
envlist = {py27,py35,py36}-{django12,django13}{,-example} | ||
|
||
[testenv] | ||
deps= | ||
|
@@ -253,13 +253,13 @@ Another `tox.ini | |
has 233 lines and runs tests against multiple Postgres and Mysql | ||
engines. It also performs backend-specific test commands, passing | ||
different command line options to the test script. With the new tox-1.X | ||
we not only can do the same with 32 non-repetive configuration lines but | ||
we not only can do the same with 35 non-repetive configuration lines but | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think this one was supposed to change |
||
we also produce 36 specific testenvs with specific dependencies and test | ||
commands:: | ||
|
||
[tox] | ||
envlist = | ||
{py24,py25,py26,py27}-{django11,django12,django13}-{nodb,pg,mysql}, docs | ||
{py27,py34,py35,py36}-{django11,django12,django13}-{nodb,pg,mysql}, docs | ||
|
||
[testenv:docs] | ||
changedir = docs | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can mention that a recent enough
pip
(>=9) should automatically install < 2.9 on Python 2.6 and Python 3.3.