feat: remove skip_clippy_and_linting flag from build command + add lint command

[chungquantin]

Summary

Closes #1989

• y/n | Does it introduce breaking changes?
• y/n | Is it dependent on the specific version of ink or pallet-contracts?

Description

• Move the linting logic from build/lib.rs to a separate lint.rs file.
• Remove skip_clippy_and_linting flag from the cargo contract build command. Adjust the lint flag to requires the --generate=check-only if the flag is provided.
• Add a new lint command to only run linting the contract.
• Add lint_code_only test.

➜ cargo contract lint --help
Lint a contract

Usage: cargo contract lint [OPTIONS]

Options:
      --manifest-path <MANIFEST_PATH>
          Path to the `Cargo.toml` of the contract to build

      --quiet
          No output printed to stdout

      --verbose
          Use verbose output

      --lint
          Performs extra linting checks for ink! specific issues during the build process.

          Basic clippy lints are deemed important and run anyway.

  -h, --help
          Print help (see a summary with '-h')

Checklist before requesting a review

• My code follows the style guidelines of this project
• I have added an entry to CHANGELOG.md
• I have commented my code, particularly in hard-to-understand areas
• I have added tests that prove my fix is effective or that my feature works
• Any dependent changes have been merged and published in downstream modules

[al3mart]

Did a quick review at it and it looks good :)

Have left a couple of comments. One regarding the change of the name for the option --lint within the lint command so it reads less repetitive and the name a bit more meaningful given this new context.

The other comment is a nit about a potential refactor of module linting which I am not sure might be worth the effort, haven't either look for usages of that module across the codebase.

[al3mart]

It seems that this is only used to run extra lints via dylint aside from clippy lints. Might be worth changing the name of the option to extra-lints or dylint.

[chungquantin]

Great! I have renamed it to dylint and updated the comment above

[davidsemakula]

@chungquantin @al3mart dylint is an implementation detail, so extra-lints is a better user-facing name if we're renaming this.

[chungquantin]

@davidsemakula I see, that makes sense and more user friendly. I reverted back to extra-lints.

[al3mart]

Looks good to me!

One consideration would be adding in some deprecation messages for the options we are removing. But I think we should be mostly OK if we decide not doing so.

[davidsemakula]

Looks good!
Except for one high-level comment 🙂

[davidsemakula]

Thanks @chungquantin