Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Armenian translation short names #1705

Closed
wants to merge 7 commits into from
Closed

Armenian translation short names #1705

wants to merge 7 commits into from

Conversation

tigranbalayan
Copy link
Contributor

Corrected armenian translation short names.

@@ -1,17 +1,16 @@
/**
* Armenian translation for bootstrap-datepicker
* Hayk Chamyan <hamshen@gmail.com>
* Tigran Balayan <balayan.tigran@gmail.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove the previous contributor, but add your name under it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok now.

@acrobat
Copy link
Member

acrobat commented Dec 7, 2015

Please only keep the specific changes and leave other lines like they were. Now all lines show as diff but only a few lines do really have changes. (also you deleted the format option)

@tigranbalayan
Copy link
Contributor Author

May be it codding style, In my code tabs, in old code are spaces.

@tigranbalayan
Copy link
Contributor Author

Should I change tab to a space?

@acrobat
Copy link
Member

acrobat commented Dec 8, 2015

Yes please don't change the indentation, that way we only see a diff of exactly the changes you made (few string changes)

@tigranbalayan
Copy link
Contributor Author

OK

@tigranbalayan
Copy link
Contributor Author

Thanks for remark.

@acrobat
Copy link
Member

acrobat commented Dec 8, 2015

Thanks @tigranbalayan

@acrobat acrobat closed this in 06fcbff Dec 8, 2015
@acrobat acrobat added this to the 1.5.1 milestone Dec 8, 2015
@tigranbalayan
Copy link
Contributor Author

Thank You too @acrobat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants