Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert strange changes, +monthsTitle #2153

Merged
merged 1 commit into from
Mar 26, 2017
Merged

Revert strange changes, +monthsTitle #2153

merged 1 commit into from
Mar 26, 2017

Conversation

hayk
Copy link
Contributor

@hayk hayk commented Mar 22, 2017

Q A
Bug fix? no
New feature? no
BC breaks? no
Related tickets fixes #X, partially #Y, mentioned in #Z
License MIT

@acrobat
Copy link
Member

acrobat commented Mar 23, 2017

These changes were submitted in #1705. @tigranbalayan what do you think about this change?

@hayk
Copy link
Contributor Author

hayk commented Mar 25, 2017

@acrobat, I have used "standart" shortening for daysShort and monthsShort, which used in books and other open source products.
Array daysMin should contains 2-chars shortening instead of 3-chars shortening as in daysShort.

@acrobat
Copy link
Member

acrobat commented Mar 25, 2017

Thanks @hayk, I will wait a few days to give @tigranbalayan some time to provide feedback. Otherwise I will merge this in a few days!

@acrobat acrobat added this to the 1.7.0 milestone Mar 25, 2017
@hayk
Copy link
Contributor Author

hayk commented Mar 25, 2017

@acrobat, thanks!

@tigranbalayan
Copy link
Contributor

Thanks @hayk @acrobat I mean it is ok to merge this change.

@acrobat
Copy link
Member

acrobat commented Mar 26, 2017

Ok thanks @hayk and @tigranbalayan!

@acrobat acrobat merged commit 50ac8fb into uxsolutions:master Mar 26, 2017
@acrobat acrobat mentioned this pull request May 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acrobat acrobat acrobat approved these changes

Assignees
No one assigned
Labels
kind-locales
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hayk @acrobat @tigranbalayan