Apply all pending changes in preparation for 8.0.1 release. #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valkey-io#1040) Since in here the monitor value is mymaster, we need to make sure the primary name is the same, otherwise the default configuration cannot start sentinel. ``` sentinel monitor mymaster 127.0.0.1 6379 2 ``` The following error occurs when the default configuration is started: ``` *** FATAL CONFIG FILE ERROR (Version 255.255.255) *** Reading the configuration file, at line 358 >>> 'SENTINEL primary-reboot-down-after-period myprimary 0' No such master with specified name. ``` Introduced in valkey-io#647. Signed-off-by: Binbin <[email protected]>
Fix a bug in the way we allocate memory for the server databases Introduced in valkey-io#156. Signed-off-by: Ran Shidlansik <[email protected]>
Apparently this will fail to compile in some masOS version. And internet claims _Thread_local is portable. Fixes valkey-io#1051. Signed-off-by: Binbin <[email protected]>
…sh (valkey-io#1063) The reason is VM_Call will use a fake client without connection, so we also need to check if c->conn is NULL. This also affects scripts. If they are called in the script, the server will crash. Injecting commands into AOF will also cause startup failure. Fixes valkey-io#1054. Signed-off-by: Binbin <[email protected]>
…#1064) The one in CLUSTER SETSLOT help us keep track of state better, of course it also can make the test case happy. The one in gossip process fixes a problem that a replica can print a log saying it is an empty primary. Signed-off-by: Binbin <[email protected]> Co-authored-by: Ping Xie <[email protected]>
For fake clients like the ones used for Lua and modules, we don't determine TLS in the right way, causing CLUSTER SLOTS from EVAL over TLS to fail a debug-assert. This error was introduced when the caching of CLUSTER SLOTS was introduced, i.e. in 8.0.0. Signed-off-by: Viktor Söderqvist <[email protected]>
RDMA module has dependence on '$(SERVER_NAME)' rather than the old style '$(REDIS_SERVER_NAME)'. Signed-off-by: zhenwei pi <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 8.0 #1099 +/- ##
==========================================
- Coverage 70.65% 70.65% -0.01%
==========================================
Files 114 114
Lines 61670 61680 +10
==========================================
+ Hits 43575 43580 +5
- Misses 18095 18100 +5
|
Signed-off-by: Madelyn Olson <[email protected]>
Apparently there is a timing issue when using wait_for_ofs_sync: ``` [exception]: Executing test client: can't read "out_before": no such variable. can't read "out_before": no such variable ``` The reason is that if the connection between the primary and the replica is not established yet, the master_repl_offset of the primary and replica in wait_for_ofs_sync is 0, and the check fails, resulting in no replica client in the client list below. In this case, we need to make sure the replica is online before proceeding. Signed-off-by: Binbin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remaining CVE fixes will be merged tomorrow before the embargo release.