Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor downloadBundleUri to Simplify Nested Conditionals and Improve Async/Await Usage #56

Closed
BangDori opened this issue Feb 22, 2025 · 2 comments

Comments

@BangDori
Copy link
Contributor

First of all, thank you for creating this library!

Currently, the downloadBundleUri function contains multiple nested if-else statements within a try block, making the logic difficult to follow and maintain. I propose to enhance error handling and overall code readability by using early returns and applying a consistent async/await pattern. May I proceed with this work?

@vantuan88291
Copy link
Owner

Sure, it great to create a PR. Thanks

@BangDori
Copy link
Contributor Author

@vantuan88291

I've added the work for this issue to #57!

vantuan88291 added a commit that referenced this issue Feb 23, 2025
Refactor downloadBundleUri with Early Returns and Consistent Async/Await (#56)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants