Refactor downloadBundleUri with Early Returns and Consistent Async/Await (#56) #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace nested if-else blocks with early returns for cleaner control flow - Use async/await consistently instead of mixing promise chains - Improve overall readability
|
Thanks, released to version 2.1.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the downloadBundleUri function to simplify its logic and improve maintainability. It addresses the concerns raised in Issue #56 by replacing nested if-else blocks with early returns and ensuring a consistent use of async/await for asynchronous operations.
Changes
return;toreturn installFail(...)to explicitly indicate error handling, improving code clarity (functionally equivalent asinstallFail()returns void).Expected Results
These changes are expected to improve the maintainability and scalability of the code. The refactored function should operate identically to the previous version while providing a clearer structure and improved error handling.
Please review and provide your feedback!