Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sagemath: update to 10.4 #49571

Closed
wants to merge 9 commits into from
Closed

Conversation

tornaria
Copy link
Contributor

@tornaria tornaria commented Mar 27, 2024

Ideally, this PR should be merged on top of #50565, so that gsl is updated beforehand (both giac + sagemath need to be rebuilt when gsl is updated).

I've tested everything locally with #50565 + this PR so it should be fine to merge both together at the same time. But checking both PRs together takes a bit over 6h so github actions will timeout.

@tornaria tornaria marked this pull request as draft March 30, 2024 21:21
@tornaria tornaria changed the title [BETA] sagemath: update to 10.4.beta0 [BETA] sagemath: update to 10.4.beta1 Apr 2, 2024
@tornaria tornaria force-pushed the sagemath branch 2 times, most recently from 12cbcf5 to e11f47b Compare April 29, 2024 00:27
@tornaria tornaria changed the title [BETA] sagemath: update to 10.4.beta1 [BETA] sagemath: update to 10.4.b4 Apr 29, 2024
@tornaria tornaria force-pushed the sagemath branch 2 times, most recently from c67a5b8 to 9531e73 Compare May 3, 2024 03:30
@tornaria tornaria changed the title [BETA] sagemath: update to 10.4.b4 [BETA] sagemath: update to 10.4.beta5 May 4, 2024
@tornaria tornaria changed the title [BETA] sagemath: update to 10.4.beta5 [BETA] sagemath: update to 10.4.beta6 May 13, 2024
@tornaria
Copy link
Contributor Author

Rebased on top of #50295, updated to sagemath 10.4.beta6

@tornaria tornaria force-pushed the sagemath branch 2 times, most recently from 7c7dd32 to a5dc20f Compare May 31, 2024 20:36
@tornaria tornaria changed the title [BETA] sagemath: update to 10.4.beta6 [BETA] sagemath: update to 10.4.beta7 May 31, 2024
@tornaria tornaria changed the title [BETA] sagemath: update to 10.4.beta7 [BETA] sagemath: update to 10.4.beta8 Jun 7, 2024
@tornaria tornaria changed the title [BETA] sagemath: update to 10.4.beta8 [BETA] sagemath: update to 10.4.beta9 Jun 12, 2024
@tornaria tornaria changed the title [BETA] sagemath: update to 10.4.beta9 [BETA] sagemath: update to 10.4.rc3 Jul 15, 2024
@tornaria tornaria changed the title [BETA] sagemath: update to 10.4.rc3 [RC] sagemath: update to 10.4.rc3 Jul 15, 2024
@tornaria tornaria changed the title [RC] sagemath: update to 10.4.rc3 [RC] sagemath: update to 10.4.rc4 Jul 17, 2024
@tornaria
Copy link
Contributor Author

@dkwo sagemath 10.4 is getting close, this works fine for me on x86_64 and passes all tests on i686 and x86_64-musl. If you want to check on aarch64 this is a good time, if there is any issue we can fix all before we merge it. I expect the final release will be almost the same as rc4 and very soon.

@tornaria
Copy link
Contributor Author

tornaria commented Jul 17, 2024

Ideally, this PR should be merged on top of #50565, so that gsl is updated beforehand (both giac + sagemath need to be rebuilt when gsl is updated).

Edit: I've tested everything locally with #50565 + this PR so it should be fine to merge both together at the same time. But checking both PRs together takes a bit over 6h so github actions will timeout.

@dkwo
Copy link
Contributor

dkwo commented Jul 18, 2024

Thanks. I won't have access to my aarch64 machines for a month or so.
I think this should be merged now, and I'll run tests once I get back.
It's great that it now builds from pypi.

@tornaria
Copy link
Contributor Author

Thanks. I won't have access to my aarch64 machines for a month or so. I think this should be merged now, and I'll run tests once I get back. It's great that it now builds from pypi.

Great: I think we can merge it once 10.4 is released.

@ahesford: my last push should support numpy 2.0 without any further change (meaning: it builds and checks fine both with numpy 1.26 and with numpy 2.0 -- bear in mind that sagemath built with 1.26 will NOT work with 2.0 so a revbump will be necessary). I'll be testing it further and let you know in case anything breaks.

@tornaria
Copy link
Contributor Author

I tested locally on x86_64 with numpy 2.0 as follows:

  • On top of this PR I merged [WIP] NumPy 2.0 #51077 (at a656cfb to be more precise).
  • From the numpy branch, I built numpy, pythran, matplotlib, scipy.
  • From the sagemath branch I rebuilt sagemath itself (nothing else needs numpy)
  • Run full check of sagemath (-K = long test, takes 35m on 8 cores): all tests passed.

@tornaria tornaria changed the title [RC] sagemath: update to 10.4.rc4 [sagemath: update to 10.4 Jul 20, 2024
@tornaria tornaria changed the title [sagemath: update to 10.4 sagemath: update to 10.4 Jul 20, 2024
@tornaria tornaria marked this pull request as ready for review July 20, 2024 21:55
@ahesford ahesford closed this in c8b116c Jul 21, 2024
@tornaria tornaria deleted the sagemath branch July 21, 2024 16:05
jlzht pushed a commit to jlzht/void-packages that referenced this pull request Aug 2, 2024
@dkwo
Copy link
Contributor

dkwo commented Aug 25, 2024

This builds and checks fine on aarch64.
At the post-install hook stage, I noticed a bunch of warning: renamed X.cpython-312-aarch64-linux-gnu.so to X.so, e.g. X = algebra_elements. Not sure if they're relevant.

@tornaria
Copy link
Contributor Author

This builds and checks fine on aarch64. At the post-install hook stage, I noticed a bunch of warning: renamed X.cpython-312-aarch64-linux-gnu.so to X.so, e.g. X = algebra_elements. Not sure if they're relevant.

This is a standard pre-pkg hook, the same happens for all python packages, xbps-src renames the libraries since the architecture part is not necessary for our distro python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants