-
-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rule-proposal: add a new line after html-closing-bracket #415
Comments
I feel like I've heard this proposition before 🤔Perhaps we were talking about it while discussing about two original rules. I don't think that we should add another responsibility for this rule. We should rather add new one, e.g. |
I see it like this: Settings:
Incorrect: <div
class="panel"
>content</div> Correct: <div class="panel">content</div>
<div class="panel">
content
</div>
<div
class="panel"
>
content
</div> Settings:
Incorrect: <div class="panel">panel</div>
<div
class="panel"
>
content
</div> Correct: <div class="panel">
content
</div>
<div
class="panel"
>content</div>
|
Looking forward to this! For reference: |
@michalsnik We just discussed this in person, but let me know if there's anything I can provide to make your work on this easier. 🙂 |
I am trying to get rid of those standalone and trailing |
What category of rule is this? (place an "X" next to just one item)
[X] Enforces code style
[ ] Warns about a potential error
[ ] Suggests an alternate way of doing something
It could be a very convenient with the
html-closing-bracket-newline
rule usage.Motivation:
Currently, this piece of html a fully valid when used with vue/recommended and this rule:
They are all different:
Suggestion
With suggested rule it could looks like the following:
But If there is no children I suggest no newline.
The text was updated successfully, but these errors were encountered: