[New] Add vue/multiline-html-element-content-newline rule
#551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 11, 2018
michalsnik
reviewed
Aug 13, 2018
| schema: [{ | ||
| type: 'object', | ||
| properties: { | ||
| 'ignoreNames': { |
There was a problem hiding this comment.
Perhaps we should stick to the convention and use simple ignore property? I don't have strong preference though
There was a problem hiding this comment.
Thank you for review!
Name was unnecessary.
Since the indent rule is named ignores, we also name it ignores.
| </div> | ||
| </template>`, | ||
| errors: [ | ||
| 'Expected 1 line break after closing bracket of the "div" element, but no line breaks found.', |
There was a problem hiding this comment.
I find closing bracket and opening bracket a little confusing. What do you think about instead using opening tag and closing tag?
So for example:
Expected 1 line break after opening tag (`<div>`), but no line breaks found.
and
Expected 1 line break before closing tag (`</div>`), but no line breaks found.
There was a problem hiding this comment.
Thank you for review!
The message you suggested is very easy to understand.
|
@michalsnik I changed it! so please check again. |
|
sadly i found issue in this rule: #662 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
vue/multiline-html-element-content-newlinerule.This implements rule proposed in #547 (comment)
It is related to #415.