[New] Add vue/singleline-html-element-content-newline rule
#552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 11, 2018
michalsnik
reviewed
Aug 13, 2018
| } | ||
| ``` | ||
|
|
||
| - `strict` ... if false, if there are no attributes on the element, this rule allows having contents in one line. |
There was a problem hiding this comment.
What do you think about renaming strict option that I proposed earlier to something a bit more descriptive, like ignoreWhenNoAttribures?
- `ignoreWhenNoAttributes` ... allows having contents in one line, when given element has no attributes. default `true`
There was a problem hiding this comment.
I think that the name ignoreWhenNoAttribures is easy to understand and very good!
| </template> | ||
| `, | ||
| errors: [ | ||
| 'Expected 1 line break after closing bracket of the "div" element, but no line breaks found.', |
There was a problem hiding this comment.
Same question as in the other rule, what do you think about using opening tag and closing tag phrases?
…s` and report messages
|
@michalsnik Thank you for the review! |
michalsnik
deleted the
add-rule/singleline-html-element-content-newline
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
vue/singleline-html-element-content-newlinerule.This implements rule proposed in #547 (comment)
It is related to #415.