Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Update] Make vue/max-attributes-per-line fixable #380

Merged
merged 5 commits into from
Feb 16, 2018
Merged

[Update] Make vue/max-attributes-per-line fixable #380

merged 5 commits into from
Feb 16, 2018

Conversation

ota-meshi
Copy link
Member

This PR makes vue/max-attributes-per-line fixable.
The autofix insert line feed at maximum number of attributes location

mysticatea
mysticatea suggested changes Feb 6, 2018
View reviewed changes
Copy link
Member

@mysticatea mysticatea left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

The direction looks good to me.
I have two requests.

  1. Please don't handle indentation. We can keep simple as delegating it to vue/html-indent rule. Each rule does one thing well and works together.
  2. Please add tests.

@mysticatea mysticatea mentioned this pull request Feb 6, 2018
Closed
@casprwang
Copy link

Nice job!

@ota-meshi
Copy link
Member Author

Thank you for confirmation.
fixed the pointed out content.
Please check again m(_ _)m

mysticatea
mysticatea reviewed Feb 6, 2018
View reviewed changes
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, very quickly.
Looks good to me!

@mysticatea mysticatea merged commit ee5cc0a into vuejs:master Feb 16, 2018
@ota-meshi ota-meshi deleted the deverop/max-attributes-per-line--fix branch February 19, 2018 16:10
michalsnik pushed a commit that referenced this pull request Feb 24, 2018
@ota-meshi @michalsnik
Update: Make vue/max-attributes-per-line fixable (#380)
742bfd6 
* [Update] Make `vue/max-attributes-per-line` fixable

* [fix] bug and style

* [fix] Switch indent calculation method with node and attribute

* [fix] don't handle indentation

* [add] autofix test max-attributes-per-line.js
michalsnik pushed a commit that referenced this pull request Apr 1, 2018
@ota-meshi @michalsnik
[Update] Make vue/attributes-order fixable (#405)
a5391f1 
* Add Vue.extend support, add missing info about Vue.mixin check in readme

* Docs: fixes wording in docs (#372)

* Fix: fix script-indent to prevent removing <script> tag (fixes #367) (#374)

*  [Update] Make `vue/max-attributes-per-line` fixable (#380)

* [Update] Make `vue/max-attributes-per-line` fixable

* [fix] bug and style

* [fix] Switch indent calculation method with node and attribute

* [fix] don't handle indentation

* [add] autofix test max-attributes-per-line.js

* Update: make `vue/order-in-components` fixable (#381)

* [Update] Make `vue/order-in-components` fixable

This Commit makes `vue/order-in-components` fixable.
In case of `The "A" property should be above the "B" property` error, autofix will move A before B

* [fix] fail test at [email protected]

* [fix] If there is a possibility of a side effect, don't autofix

* [fix] failed test at node v4

* [update] use Traverser

* [fix] failed test [email protected]

* [fix] I used `output: null` to specify "not fix"

* Fix: no-async-in-computed-properties crash (fixes #390)

* Fix: valid-v-on false positive (fixes #351)

* Fix: indent rules false positive (fixes #375)

* [New] Add `prop-name-casing`

* fix message and category

* fix category

* fix test message

* Set category to undefined

* Add more tests and fix edge case scenario

* attribute order linting

* updating docs, tests and category

* [Update] Make `vue/attributes-order` fixable

* [fix] That `vue/attributes-order` got duplicated when merging README

* [add] messed order properties test case

* [fix] unify input on test case
michalsnik pushed a commit that referenced this pull request Jul 11, 2018
@ota-meshi @michalsnik
⭐️New: Add vue/no-use-v-if-with-v-for rule (#406)
a95dfbb 
* Add Vue.extend support, add missing info about Vue.mixin check in readme

* Docs: fixes wording in docs (#372)

* Fix: fix script-indent to prevent removing <script> tag (fixes #367) (#374)

*  [Update] Make `vue/max-attributes-per-line` fixable (#380)

* [Update] Make `vue/max-attributes-per-line` fixable

* [fix] bug and style

* [fix] Switch indent calculation method with node and attribute

* [fix] don't handle indentation

* [add] autofix test max-attributes-per-line.js

* Update: make `vue/order-in-components` fixable (#381)

* [Update] Make `vue/order-in-components` fixable

This Commit makes `vue/order-in-components` fixable.
In case of `The "A" property should be above the "B" property` error, autofix will move A before B

* [fix] fail test at [email protected]

* [fix] If there is a possibility of a side effect, don't autofix

* [fix] failed test at node v4

* [update] use Traverser

* [fix] failed test [email protected]

* [fix] I used `output: null` to specify "not fix"

* Fix: no-async-in-computed-properties crash (fixes #390)

* Fix: valid-v-on false positive (fixes #351)

* Fix: indent rules false positive (fixes #375)

* [New] Add `prop-name-casing`

* fix message and category

* fix category

* fix test message

* Set category to undefined

* Add more tests and fix edge case scenario

* attribute order linting

* updating docs, tests and category

*  [New] Add rule `vue/no-use-v-if-with-v-for` (#2)

* [fix] `meta.docs.description` should not end with `.`  consistent-docs-description

* [fix] lint error caused by merging the master for conflict resolution

* [fix] That `vue/attributes-order` got duplicated when merging README

* [fixed] document `correct` and `incorrect` the contrary stated

* [fixed] error message
michalsnik pushed a commit that referenced this pull request Jul 30, 2018
@ota-meshi @michalsnik
⭐️New: Add vue/component-name-in-template-casing (#397)
c49a2e2 
* Add Vue.extend support, add missing info about Vue.mixin check in readme

* Docs: fixes wording in docs (#372)

* Fix: fix script-indent to prevent removing <script> tag (fixes #367) (#374)

*  [Update] Make `vue/max-attributes-per-line` fixable (#380)

* [Update] Make `vue/max-attributes-per-line` fixable

* [fix] bug and style

* [fix] Switch indent calculation method with node and attribute

* [fix] don't handle indentation

* [add] autofix test max-attributes-per-line.js

* Update: make `vue/order-in-components` fixable (#381)

* [Update] Make `vue/order-in-components` fixable

This Commit makes `vue/order-in-components` fixable.
In case of `The "A" property should be above the "B" property` error, autofix will move A before B

* [fix] fail test at [email protected]

* [fix] If there is a possibility of a side effect, don't autofix

* [fix] failed test at node v4

* [update] use Traverser

* [fix] failed test [email protected]

* [fix] I used `output: null` to specify "not fix"

* [New] Add `vue/component-name-in-template-casing`

* [update] documents

* [fix] require-meta-docs-url

* [fix] failed tests

* [fix] review contents

* Default case to constant. and used it. `const defaultCase = 'PascalCase'`
* `'category'` to `undefined`
* Add empty line for clarity
* I used object shorthand. `caseType: caseType` to `caseType`

* [fix] No deletes space and attributes of endTag

* [fix] Remove test unnecessary option

* [fix] lint error caused by merging the master for conflict resolution

* Add ignores option.

* Fixed that extra differences.

* update docs link

* Update formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysticatea mysticatea mysticatea approved these changes

Assignees
No one assigned
Labels
enhancement semver-minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ota-meshi @casprwang @mysticatea