[Update] Make `vue/order-in-components` fixable #381

ota-meshi · 2018-02-07T02:37:46Z

This PR makes vue/order-in-components fixable. #299
In case of The "A" property should be above the "B" property error, autofix will move A before B

This Commit makes `vue/order-in-components` fixable. In case of `The "A" property should be above the "B" property` error, autofix will move A before B

mysticatea · 2018-02-16T02:23:35Z

Thank you for the contribution! And I make apologies that I overlooked this PR. 🙇

Reordering needs to handle carefully because each property value can have side-effects. So ESLint core rules don't support reordering in autofix basically.

In this case, I think we can support reordering if it's sure those properties don't have side-effects.
Would you add the check whether all properties don't have side-effects into the fix() function? As details, all computed property keys and all property values don't contain CallExpression, NewExpression, UpdateExpression, AssignmentExpression, and TaggedTemplateExpression.

ota-meshi · 2018-02-17T01:10:03Z

Thank you for checking.

I changed it to run fix() only when it's sure that there are no side effects.

In order to prevent side effects from future ES changes, it runs fix() only when all and each of the properties have node.type that do not cause side effects as far as I know, in them.

Although implementation has become complex, I think this is the only way to fully prevent troubles. However, it has become complex, so I would appreciate your feedback on whether to actually implement this change.

mysticatea

Looks great!

I'm afraid a bit to use internal API of ESLint, but I'm OK since it's a long-living class.

mysticatea · 2018-02-17T07:30:43Z

tests/lib/rules/order-in-components.js

+        };
+      `,
+      parserOptions,
+      output: `


Would you use output: null to specify "not fix" explicitly?

I did not know that. Thank you for the information.

ota-meshi · 2018-02-17T08:46:21Z

Thank you for review!
I changed it again, so please check it.

mysticatea

LGTM, thank you very much!

ota-meshi · 2018-02-17T09:04:51Z

I'm glad you approved!
I appreciate your quick response 😸

* [Update] Make `vue/order-in-components` fixable This Commit makes `vue/order-in-components` fixable. In case of `The "A" property should be above the "B" property` error, autofix will move A before B * [fix] fail test at [email protected] * [fix] If there is a possibility of a side effect, don't autofix * [fix] failed test at node v4 * [update] use Traverser * [fix] failed test [email protected] * [fix] I used `output: null` to specify "not fix"

* Add Vue.extend support, add missing info about Vue.mixin check in readme * Docs: fixes wording in docs (#372) * Fix: fix script-indent to prevent removing <script> tag (fixes #367) (#374) * [Update] Make `vue/max-attributes-per-line` fixable (#380) * [Update] Make `vue/max-attributes-per-line` fixable * [fix] bug and style * [fix] Switch indent calculation method with node and attribute * [fix] don't handle indentation * [add] autofix test max-attributes-per-line.js * Update: make `vue/order-in-components` fixable (#381) * [Update] Make `vue/order-in-components` fixable This Commit makes `vue/order-in-components` fixable. In case of `The "A" property should be above the "B" property` error, autofix will move A before B * [fix] fail test at [email protected] * [fix] If there is a possibility of a side effect, don't autofix * [fix] failed test at node v4 * [update] use Traverser * [fix] failed test [email protected] * [fix] I used `output: null` to specify "not fix" * Fix: no-async-in-computed-properties crash (fixes #390) * Fix: valid-v-on false positive (fixes #351) * Fix: indent rules false positive (fixes #375) * [New] Add `prop-name-casing` * fix message and category * fix category * fix test message * Set category to undefined * Add more tests and fix edge case scenario * attribute order linting * updating docs, tests and category * [Update] Make `vue/attributes-order` fixable * [fix] That `vue/attributes-order` got duplicated when merging README * [add] messed order properties test case * [fix] unify input on test case

* Add Vue.extend support, add missing info about Vue.mixin check in readme * Docs: fixes wording in docs (#372) * Fix: fix script-indent to prevent removing <script> tag (fixes #367) (#374) * [Update] Make `vue/max-attributes-per-line` fixable (#380) * [Update] Make `vue/max-attributes-per-line` fixable * [fix] bug and style * [fix] Switch indent calculation method with node and attribute * [fix] don't handle indentation * [add] autofix test max-attributes-per-line.js * Update: make `vue/order-in-components` fixable (#381) * [Update] Make `vue/order-in-components` fixable This Commit makes `vue/order-in-components` fixable. In case of `The "A" property should be above the "B" property` error, autofix will move A before B * [fix] fail test at [email protected] * [fix] If there is a possibility of a side effect, don't autofix * [fix] failed test at node v4 * [update] use Traverser * [fix] failed test [email protected] * [fix] I used `output: null` to specify "not fix" * Fix: no-async-in-computed-properties crash (fixes #390) * Fix: valid-v-on false positive (fixes #351) * Fix: indent rules false positive (fixes #375) * [New] Add `prop-name-casing` * fix message and category * fix category * fix test message * Set category to undefined * Add more tests and fix edge case scenario * attribute order linting * updating docs, tests and category * [New] Add rule `vue/no-use-v-if-with-v-for` (#2) * [fix] `meta.docs.description` should not end with `.` consistent-docs-description * [fix] lint error caused by merging the master for conflict resolution * [fix] That `vue/attributes-order` got duplicated when merging README * [fixed] document `correct` and `incorrect` the contrary stated * [fixed] error message

bbugh · 2018-07-13T20:44:24Z

This doesn't seem to work when I've customized an extra property that I want to have automatically sorted. I notice a discussion about side effects. Is there a way to tell it to automatically fix "unapproved" properties as well? We want it in a specific order on purpose, not just as a warning. If I remove the item from the rule list (validations in this case), then everything sorts again.

michalsnik · 2018-07-16T16:51:14Z

Please fire a separate issue Brian with more informations :)

…

On 13 Jul 2018, 22:44 +0200, Brian Bugh ***@***.***>, wrote: This doesn't seem to work when I've customized an extra property that I want to have automatically sorted. I notice a discussion about side effects. Is there a way to tell it to automatically fix "unapproved" properties as well? We want it in a specific order on purpose, not just as a warning. If I remove the item from the rule list (validations in this case), then everything sorts again. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

bbugh · 2018-07-16T18:43:17Z

Thank you for confirming that it is an issue, I will make a new issue.

* Add Vue.extend support, add missing info about Vue.mixin check in readme * Docs: fixes wording in docs (#372) * Fix: fix script-indent to prevent removing <script> tag (fixes #367) (#374) * [Update] Make `vue/max-attributes-per-line` fixable (#380) * [Update] Make `vue/max-attributes-per-line` fixable * [fix] bug and style * [fix] Switch indent calculation method with node and attribute * [fix] don't handle indentation * [add] autofix test max-attributes-per-line.js * Update: make `vue/order-in-components` fixable (#381) * [Update] Make `vue/order-in-components` fixable This Commit makes `vue/order-in-components` fixable. In case of `The "A" property should be above the "B" property` error, autofix will move A before B * [fix] fail test at [email protected] * [fix] If there is a possibility of a side effect, don't autofix * [fix] failed test at node v4 * [update] use Traverser * [fix] failed test [email protected] * [fix] I used `output: null` to specify "not fix" * [New] Add `vue/component-name-in-template-casing` * [update] documents * [fix] require-meta-docs-url * [fix] failed tests * [fix] review contents * Default case to constant. and used it. `const defaultCase = 'PascalCase'` * `'category'` to `undefined` * Add empty line for clarity * I used object shorthand. `caseType: caseType` to `caseType` * [fix] No deletes space and attributes of endTag * [fix] Remove test unnecessary option * [fix] lint error caused by merging the master for conflict resolution * Add ignores option. * Fixed that extra differences. * update docs link * Update formatting

ota-meshi added 2 commits February 7, 2018 11:15

[Update] Make vue/order-in-components fixable

3ec9077

This Commit makes `vue/order-in-components` fixable. In case of `The "A" property should be above the "B" property` error, autofix will move A before B

[fix] fail test at [email protected]

2800f00

mysticatea added enhancement semver-minor labels Feb 16, 2018

ota-meshi added 4 commits February 16, 2018 17:15

[fix] If there is a possibility of a side effect, don't autofix

ac62bb7

[fix] failed test at node v4

bccb03d

[update] use Traverser

b7cc350

[fix] failed test [email protected]

ef9e1c0

mysticatea reviewed Feb 17, 2018

View reviewed changes

[fix] I used output: null to specify "not fix"

7440ee1

mysticatea approved these changes Feb 17, 2018

View reviewed changes

mysticatea merged commit 6861c81 into vuejs:master Feb 17, 2018

ota-meshi deleted the develop/order-in-components--fixable branch February 19, 2018 16:10

bbugh mentioned this pull request Jul 16, 2018

--fix fails on custom options in order-in-components #523

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Update] Make `vue/order-in-components` fixable #381

[Update] Make `vue/order-in-components` fixable #381

ota-meshi commented Feb 7, 2018

mysticatea commented Feb 16, 2018

ota-meshi commented Feb 17, 2018

mysticatea left a comment

mysticatea Feb 17, 2018

ota-meshi Feb 17, 2018

ota-meshi commented Feb 17, 2018

mysticatea left a comment

ota-meshi commented Feb 17, 2018

bbugh commented Jul 13, 2018

michalsnik commented Jul 16, 2018 via email

bbugh commented Jul 16, 2018

[Update] Make vue/order-in-components fixable #381

[Update] Make vue/order-in-components fixable #381

Conversation

ota-meshi commented Feb 7, 2018

mysticatea commented Feb 16, 2018

ota-meshi commented Feb 17, 2018

mysticatea left a comment

Choose a reason for hiding this comment

mysticatea Feb 17, 2018

Choose a reason for hiding this comment

ota-meshi Feb 17, 2018

Choose a reason for hiding this comment

ota-meshi commented Feb 17, 2018

mysticatea left a comment

Choose a reason for hiding this comment

ota-meshi commented Feb 17, 2018

bbugh commented Jul 13, 2018

michalsnik commented Jul 16, 2018 via email

bbugh commented Jul 16, 2018

[Update] Make `vue/order-in-components` fixable #381

[Update] Make `vue/order-in-components` fixable #381