Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] Add vue/multiline-html-element-content-newline rule #551

Merged
merged 3 commits into from
Aug 13, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ Enforce all the rules in this category, as well as all higher priority rules, wi
| | Rule ID | Description |
|:---|:--------|:------------|
| :wrench: | [vue/component-name-in-template-casing](./docs/rules/component-name-in-template-casing.md) | enforce specific casing for the component naming style in template |
| :wrench: | [vue/multiline-html-element-content-newline](./docs/rules/multiline-html-element-content-newline.md) | require a line break before and after the contents of a multiline element |
| :wrench: | [vue/no-spaces-around-equal-signs-in-attribute](./docs/rules/no-spaces-around-equal-signs-in-attribute.md) | disallow spaces around equal signs in attribute |
| :wrench: | [vue/script-indent](./docs/rules/script-indent.md) | enforce consistent indentation in `<script>` |

Expand Down
87 changes: 87 additions & 0 deletions docs/rules/multiline-html-element-content-newline.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
# require a line break before and after the contents of a multiline element (vue/multiline-html-element-content-newline)

- :wrench: The `--fix` option on the [command line](https://eslint.org/docs/user-guide/command-line-interface#fixing-problems) can automatically fix some of the problems reported by this rule.

## :book: Rule Details

This rule enforces a line break before and after the contents of a multiline element.


:-1: Examples of **incorrect** code:

```html
<div>multiline
content</div>

<div
attr
>multiline start tag</div>

<tr><td>multiline</td>
<td>children</td></tr>

<div><!-- multiline
comment --></div>

<div
></div>
```

:+1: Examples of **correct** code:

```html
<div>
multiline
content
</div>

<div
attr
>
multiline start tag
</div>

<tr>
<td>multiline</td>
<td>children</td>
</tr>

<div>
<!-- multiline
comment -->
</div>

<div
>
</div>

<div attr>singleline element</div>
```


## :wrench: Options

```json
{
"vue/multiline-html-element-content-newline": ["error", {
"ignores": ["pre", "textarea"]
}]
}
```

- `ignores` ... the configuration for element names to ignore line breaks style.
default `["pre", "textarea"]`


:+1: Examples of **correct** code:

```html
/* eslint vue/multiline-html-element-content-newline: ["error", { "ignores": ["VueComponent", "pre", "textarea"]}] */

<VueComponent>multiline
content</VueComponent>

<VueComponent><span
class="bold">For example,</span>
Defines the Vue component that accepts preformatted text.</VueComponent>
```
1 change: 1 addition & 0 deletions lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
'html-self-closing': require('./rules/html-self-closing'),
'jsx-uses-vars': require('./rules/jsx-uses-vars'),
'max-attributes-per-line': require('./rules/max-attributes-per-line'),
'multiline-html-element-content-newline': require('./rules/multiline-html-element-content-newline'),
'mustache-interpolation-spacing': require('./rules/mustache-interpolation-spacing'),
'name-property-casing': require('./rules/name-property-casing'),
'no-async-in-computed-properties': require('./rules/no-async-in-computed-properties'),
Expand Down
157 changes: 157 additions & 0 deletions lib/rules/multiline-html-element-content-newline.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,157 @@
/**
* @author Yosuke Ota
* See LICENSE file in root directory for full license.
*/
'use strict'

// ------------------------------------------------------------------------------
// Requirements
// ------------------------------------------------------------------------------

const utils = require('../utils')

// ------------------------------------------------------------------------------
// Helpers
// ------------------------------------------------------------------------------

function isMultilineElement (element) {
return element.loc.start.line < element.endTag.loc.start.line
}

function parseOptions (options) {
return Object.assign({
'ignores': ['pre', 'textarea']
}, options)
}

function getPhrase (lineBreaks) {
switch (lineBreaks) {
case 0: return 'no'
default: return `${lineBreaks}`
}
}
/**
* Check whether the given element is empty or not.
* This ignores whitespaces, doesn't ignore comments.
* @param {VElement} node The element node to check.
* @param {SourceCode} sourceCode The source code object of the current context.
* @returns {boolean} `true` if the element is empty.
*/
function isEmpty (node, sourceCode) {
const start = node.startTag.range[1]
const end = node.endTag.range[0]
return sourceCode.text.slice(start, end).trim() === ''
}

// ------------------------------------------------------------------------------
// Rule Definition
// ------------------------------------------------------------------------------

module.exports = {
meta: {
docs: {
description: 'require a line break before and after the contents of a multiline element',
category: undefined,
url: 'https://github.com/vuejs/eslint-plugin-vue/blob/v5.0.0-beta.2/docs/rules/multiline-html-element-content-newline.md'
},
fixable: 'whitespace',
schema: [{
type: 'object',
properties: {
'ignores': {
type: 'array',
items: { type: 'string' },
uniqueItems: true,
additionalItems: false
}
},
additionalProperties: false
}],
messages: {
unexpectedAfterClosingBracket: 'Expected 1 line break after opening tag (`<{{name}}>`), but {{actual}} line breaks found.',
unexpectedBeforeOpeningBracket: 'Expected 1 line break before closing tag (`</{{name}}>`), but {{actual}} line breaks found.'
}
},

create (context) {
const ignores = parseOptions(context.options[0]).ignores
const template = context.parserServices.getTemplateBodyTokenStore && context.parserServices.getTemplateBodyTokenStore()
const sourceCode = context.getSourceCode()

let inIgnoreElement

return utils.defineTemplateBodyVisitor(context, {
'VElement' (node) {
if (inIgnoreElement) {
return
}
if (ignores.indexOf(node.name) >= 0) {
// ignore element name
inIgnoreElement = node
return
}
if (node.startTag.selfClosing || !node.endTag) {
// self closing
return
}

if (!isMultilineElement(node)) {
return
}

const getTokenOption = { includeComments: true, filter: (token) => token.type !== 'HTMLWhitespace' }
const contentFirst = template.getTokenAfter(node.startTag, getTokenOption)
const contentLast = template.getTokenBefore(node.endTag, getTokenOption)

const beforeLineBreaks = contentFirst.loc.start.line - node.startTag.loc.end.line
const afterLineBreaks = node.endTag.loc.start.line - contentLast.loc.end.line
if (beforeLineBreaks !== 1) {
context.report({
node: template.getLastToken(node.startTag),
loc: {
start: node.startTag.loc.end,
end: contentFirst.loc.start
},
messageId: 'unexpectedAfterClosingBracket',
data: {
name: node.name,
actual: getPhrase(beforeLineBreaks)
},
fix (fixer) {
const range = [node.startTag.range[1], contentFirst.range[0]]
return fixer.replaceTextRange(range, '\n')
}
})
}

if (isEmpty(node, sourceCode)) {
return
}

if (afterLineBreaks !== 1) {
context.report({
node: template.getFirstToken(node.endTag),
loc: {
start: contentLast.loc.end,
end: node.endTag.loc.start
},
messageId: 'unexpectedBeforeOpeningBracket',
data: {
name: node.name,
actual: getPhrase(afterLineBreaks)
},
fix (fixer) {
const range = [contentLast.range[1], node.endTag.range[0]]
return fixer.replaceTextRange(range, '\n')
}
})
}
},
'VElement:exit' (node) {
if (inIgnoreElement === node) {
inIgnoreElement = null
}
}
})
}
}
Loading