feat(lint): add max-warnings for cli-plugin-eslint, close #1268

[jkzing]

add a --max-warnings and --max-errors option for cli-plugin-eslint to specify number of warnings or errors to trigger build failed.

usage:

vue-cli-service lint --max-warnings 10 --max-errors 2

#1268

https://eslint.org/docs/user-guide/command-line-interface#options

[BenoitAverty]

The action on the status code is missing I think. The goal is to make the CLI exit with status >0 when the number of warings is greater than the parameter.

[jkzing]

@BenoitAverty

The action on the status code is missing I think

Sorry but I didn't get your point...what is your expected behavior...😂

make the CLI exit with status >0 when the number of warings is greater than the parameter

Yes, it is now.

[BenoitAverty]

Does report.errorCount includes warnings ?

[BenoitAverty]

The expected behaviour is :

• When there is one or more error, exit with status 1 (this is already the case)
• When the number of warnings is greater than the parameter, exit with status 1 (This isn't the case currently, warnings don't make the exit code change to 1)
• Otherwise, exit with status code 0

Examples:

# With 0 errors and 1 warning
vue-cli-service lint --max-warnings=1 # success.
vue-cli-service lint --max-warnings=0 # failure <-- this doesn't work currently

# With 1 error
vue-cli-service lint --max-warnings=0 # failure
vue-cli-service lint --max-warnings=1 # still failure (max warnings is only about warnings)

[jkzing]

@BenoitAverty
I think I did misunderstand the usage of --max-warnings in eslint cli.

In eslint cli, --max-warnings only take effect on warnings, for errors the cli always exit with code 1.

But in current cli-plugin-eslint, it only exit 1 for errors, and for result that only contain warnings, it always exit 0.

So I think count both warnings and errors in --max-warnings is a little bit confusing, --max-errors would be more suitable here.

[BenoitAverty]

This should do the trick :) Thanks for this.