Update system view show_create #15825
Conversation
|
🔴 PR description is empty. Please fill it out. |
shnikd
force-pushed
the
show-create-sysview
branch
from
6ef42ad to
b75a212
Compare
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| @@ -253,6 +254,14 @@ class TScanActorBase : public TActorBootstrapped<TDerived> { | |||
|
|
|||
| AllowedByLimiter = true; | |||
|
|
|||
| if (TableId.SysViewInfo == ShowCreateName) { | |||
There was a problem hiding this comment.
а может тогда выполнение резолва вынести в какую то функцию и переопределить ее для скана в show create table? выглядит странно
| } | ||
|
|
||
| if (cellsFrom[0].AsBuf() != cellsTo[0].AsBuf() || cellsFrom[1].AsBuf() != cellsTo[1].AsBuf()) { | ||
| ReplyErrorAndDie(Ydb::StatusIds::SCHEME_ERROR, "Invalid table range"); | ||
| return; |
There was a problem hiding this comment.
совмещаете фичу и багфиксы в одном PR?
| TExprBase currentNode(node); | ||
| if (auto maybeReadTable = currentNode.Maybe<TKiReadTable>()) { | ||
| auto readTable = maybeReadTable.Cast(); | ||
| for (auto setting : readTable.Settings()) { |
There was a problem hiding this comment.
костыль какой то? зачем это нужно?
There was a problem hiding this comment.
Чтобы вывести настройку для таблицы, что это переписанный Show Create Table
|
|
||
| { | ||
| auto result = session.ExecuteQuery(R"( | ||
| SELECT * FROM `.sys/show_create` WHERE Path = "/Root/test_show_create" and PathType = "Table"; |
There was a problem hiding this comment.
нам надо скрыть эту sysview в схеме, не понятно, зачем запрещать к ней делать такой select. много мороки, а профита ноль
There was a problem hiding this comment.
Тогда странно, что ты не можешь подескрайбить этот путь, но при этом можешь выполнить к нему select, выглядит как бага
There was a problem hiding this comment.
не понимаю сути баги. из за того, что ты это хочешь запретить пишется куча кода, который примерно на выброс
| @@ -191,7 +195,7 @@ class TKikimrTablesData : public TThrRefBase { | |||
| TKikimrTablesData& operator=(const TKikimrTablesData&) = delete; | |||
|
|
|||
| TKikimrTableDescription& GetOrAddTable(const TString& cluster, const TString& database, const TString& table, | |||
| ETableType tableType = ETableType::Table); | |||
| ETableType tableType = ETableType::Table, bool showCreate = false); | |||
There was a problem hiding this comment.
нейминг странный. на каждую новую таблицу будет новая булка добавляться?
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| @@ -177,11 +177,15 @@ class TKikimrTableDescription { | |||
| ETableType GetTableType() const { return TableType; } | |||
| void SetTableType(ETableType tableType) { TableType = tableType; } | |||
|
|
|||
| void SetSysViewRewritten(bool flag) { SysViewRewritten = flag; } | |||
| bool GetSysViewRewritten() const { return SysViewRewritten; } | |||
There was a problem hiding this comment.
не понимаю что на что переписывается в этом нейминге. в целом конечно стало получше, но может тогда просто написать что это Hidden системная таблица?
| NThreading::TFuture<TTableMetadataResult> tableMetaFuture; | ||
|
|
||
| NSysView::ISystemViewResolver::TSystemViewPath sysViewPath; | ||
| if (settings.SysViewRewritten_ && SystemViewRewrittenResolver->IsSystemViewPath(SplitPath(table), sysViewPath)) { |
There was a problem hiding this comment.
а QueryReplay будет поддерживать Resolve такой таблицы?
No description provided.