Skip to content

Allow empty inputs for stage compilation #17009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

nikvas0
Copy link
Collaborator

@nikvas0 nikvas0 commented Apr 9, 2025

Changelog entry

Fixed #16938: error while compiling JOIN with one side been empty constant.

Changelog category

  • Bugfix

Description for reviewers

Allow empty inputs for stage compilation.
Better fix would be eliminating empty inputs during optimization, but preparing such fix will take time. Thus we'll do it later (here #17010).

Copy link

github-actions bot commented Apr 9, 2025

2025-04-09 19:54:25 UTC Pre-commit check linux-x86_64-release-asan for c23ec2d has started.
2025-04-09 19:54:54 UTC Artifacts will be uploaded here
2025-04-09 19:58:12 UTC ya make is running...
🟡 2025-04-09 21:11:55 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12536 12398 0 67 32 39

2025-04-09 21:12:59 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-09 21:28:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
186 (only retried tests) 99 0 36 16 35

2025-04-09 21:28:30 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-09 21:41:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
120 (only retried tests) 48 0 35 4 33

🟢 2025-04-09 21:41:20 UTC Build successful.
🟢 2025-04-09 21:41:51 UTC ydbd size 3.9 GiB changed* by +16 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6853d24 merge: c23ec2d diff diff %
ydbd size 4 136 601 624 Bytes 4 136 601 640 Bytes +16 Bytes +0.000%
ydbd stripped size 1 428 737 224 Bytes 1 428 737 160 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Apr 9, 2025

🟢 2025-04-09 19:56:42 UTC The validation of the Pull Request description is successful.

@github-actions github-actions bot added bugfix and removed bugfix labels Apr 9, 2025
Copy link

github-actions bot commented Apr 9, 2025

2025-04-09 19:56:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for c23ec2d has started.
2025-04-09 19:57:02 UTC Artifacts will be uploaded here
2025-04-09 19:59:45 UTC ya make is running...
🟡 2025-04-09 21:04:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27105 24436 0 2 2554 113

2025-04-09 21:06:34 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-09 21:16:21 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
162 (only retried tests) 59 0 0 0 103

🟢 2025-04-09 21:16:28 UTC Build successful.
🟢 2025-04-09 21:16:46 UTC ydbd size 2.2 GiB changed* by -128 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 6853d24 merge: c23ec2d diff diff %
ydbd size 2 357 628 864 Bytes 2 357 628 736 Bytes -128 Bytes -0.000%
ydbd stripped size 492 806 944 Bytes 492 806 880 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nikvas0 nikvas0 merged commit 6d790e7 into ydb-platform:main Apr 10, 2025
22 of 23 checks passed
GrigoriyPA pushed a commit to GrigoriyPA/ydb that referenced this pull request Apr 10, 2025
GrigoriyPA added a commit that referenced this pull request Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go tests starts failed on nightly build with error Cost Based Optimizer could not be applied to this query
3 participants