Skip to content

merge to ydb stable Allow empty inputs for stage compilation (#17009) #17082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

GrigoriyPA
Copy link
Collaborator

Changelog entry

Fixed #16938: error while compiling JOIN with one side been empty constant.

Changelog category

  • Bugfix

Description for reviewers

Allow empty inputs for stage compilation.
Better fix would be eliminating empty inputs during optimization, but preparing such fix will take time. Thus we'll do it later (here #17010).

@GrigoriyPA GrigoriyPA requested a review from a team as a code owner April 10, 2025 14:44
@GrigoriyPA GrigoriyPA requested a review from uzhastik April 10, 2025 14:44
Copy link

github-actions bot commented Apr 10, 2025

2025-04-10 14:48:40 UTC Pre-commit check for be8130b has started.
2025-04-10 14:51:18 UTC Build linux-x86_64-release-asan is running...
🟢 2025-04-10 15:15:32 UTC Build successful.
2025-04-10 15:15:51 UTC Tests are running...
🔴 2025-04-10 17:27:14 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10434 10328 0 30 25 51

Copy link

github-actions bot commented Apr 10, 2025

2025-04-10 14:48:49 UTC Pre-commit check for be8130b has started.
2025-04-10 14:51:34 UTC Build linux-x86_64-release-clang14 is running...
🔴 2025-04-10 14:55:18 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Apr 10, 2025

2025-04-10 14:54:38 UTC Pre-commit check for be8130b has started.
2025-04-10 14:57:21 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-04-10 15:37:49 UTC Build successful.
2025-04-10 15:38:06 UTC Tests are running...
🔴 2025-04-10 17:29:44 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39079 33775 0 24 5234 46

@GrigoriyPA GrigoriyPA merged commit 3540aa2 into ydb-platform:q-stable-ydb-24-4 Apr 11, 2025
6 of 12 checks passed
@GrigoriyPA GrigoriyPA deleted the merge-to-ydb-stable-fix-empty-join branch April 11, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants