-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand support for Aqara E1 Thermostat #2109
Conversation
Pull Request Test Coverage Report for Build 3934025323
💛 - Coveralls |
Codecov ReportBase: 83.55% // Head: 83.03% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #2109 +/- ##
==========================================
- Coverage 83.55% 83.03% -0.52%
==========================================
Files 252 252
Lines 8128 8205 +77
==========================================
+ Hits 6791 6813 +22
- Misses 1337 1392 +55
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
What is the cluster command to turn on/off the thermostat? |
On/off is system_mode (0x0271). 0 for off, 1 for on. service: zha.set_zigbee_cluster_attribute |
@puddly you have this device right? I thought it worked OOTB for standard functions? |
Yeah, it shows up as a thermostat for me without a quirk. Perhaps there are multiple firmware revisions? It reports its current temperature. Adjusting the setpoint in the frontend causes the plunger to move appropriately and for the display's temperature setting to change. Mine is
There is no OTA cluster. |
It looks like this is working fine here. I haven't tested OTA though. |
Working fine, but can't test OTA (already latest firmware). |
Looking at the quirk, it seems like the Aqara E1 thermostat has a "hidden" OTA cluster. |
I know this isn't great, but would you be willing to split the Splitting that off into another PR would keep this one relatively simple, so we can merge it (it would mostly just be the added custom Xiaomi attributes). If the attributes are properly present then, we can start creating sensors in ZHA (HA Core) for them. |
@TheJulianJES |
Since I moved my system to z2m I really can't test any changes anymore. |
Alright, thanks. |
@jymdman Ah, one last thing. Could you send a screenshot of how Z2M shows the thermostat in HA? |
@TheJulianJES Sure! Attaching a screenshot... |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
Any updates on this one? @TheJulianJES @jymdman ? |
This PR expands the support for Aqara E1 Thermostat.
Known issues: