-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aqara E1 thermostat external temperature sensor #2802
base: dev
Are you sure you want to change the base?
Conversation
bc5e507
to
09ac057
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2802 +/- ##
==========================================
- Coverage 87.61% 87.17% -0.44%
==========================================
Files 295 295
Lines 9032 9094 +62
==========================================
+ Hits 7913 7928 +15
- Misses 1119 1166 +47 ☔ View full report in Codecov by Sentry. |
What is the status here? I could help implement or test, as I would also like to use this feature in the future :-) |
Hi @fzob, feel free. The new cluster appears in the ZHA device tab and I can send command to it. But if I read them they are not changed. My guess is, that the message is not correct, but I didn‘t find the time to debug it. |
Indents are wrong on line 403-567. So custom attributes weren't written. After this fix setting sensor and sensor_temp works! |
@fzob I fixed it. Coverage could gave a hint on that 🤦 . Anyway, thanks for taking a look. Now, it also works for me. |
@mb1248 I have added this quirk to my ZHA, now I am asking myself a very stupid question. |
Hi @Patrick-DE, you need to add an automation. The sensor value is either internal (Default/0) or external, meaning that the internal temperature sensor is either used or not. If an external sensor is selected, the temperature value has to be set manually. This works similarly to how the Aqara hub operates. Note that, due to compatibility with Z2M, the temperature value is in centi-degrees (c°C), so you have to multiply it by 100. (This seems awkward, and I'm considering changing it.) I also read that the sensor type is reset; however, I didn't observe this in my test (around 2 hours). Therefore, the automation for Z2M, first, set the sensor type and then the temperature value. |
Hi, I'm trying to add an automation based on this quirk. Unfortunately I'm stuck when trying to pass the value of the external sensor... That's what I'm trying to do and it ends up with 0° in the TRV current temperature :
It works fine when putting an hardcoded value like 2100, though... Would you have any idea? |
you have to pass an integer, after the multiplication add |int and it should work |
Nevermind, I'm stoopid... That works with the right parenthesis
Thanks |
I someone wants to try your quirk that's how I made it work as a whole for one TRV, once I migrate the other 9, I'll just add some triggers and template up the ieee (or duplicate the actions if I can't generate the ieee in a template) :
|
Hi. Is there any chance this gets merged soon? Is this blocked only by testing? If that’s the case, I can maybe help. |
@Antoninj I had no time to work on the test. The quirk is working. So only the testing is missing. Would be nice if you could help there. |
Thanks, it works for me too! |
It seem to work for a few people here. When can the PR get resolved? Is there still stuff to do? Would love to use the feature. :) I also tried the custom quirk and @DamGranger automation. Works like a charm |
How is it going? Will it be working? It's last thing i have on z2m :< |
Would love this feature as well :) |
Yes It would be nice👍 |
Any update on this? It would be a nice feature to add 👍 |
Is there any update on this? |
Can this be merged please? I really want to switch from z2m to zha and this is the only reason i cen't |
The situation seems to be still the same, with tests missing in the PR. |
Can somebody add them? I thing that should be quick thing to do. |
Update: I've opened a new PR containing changes from this PR + the missing tests |
Proposed change
Support for external temperature sensor.
Additional information
This is a copy of the not merged part from #2109. Discussion starts under #2687
Checklist
pre-commit
checks pass / the code has been formatted using Black