Add support for Aqara external temperature sensor

[Antoninj]

Proposed change

Support for external temperature sensor.

Additional information

This is a copy of #2802 + the missing unit tests

Checklist

• The changes are tested and work correctly
• pre-commit checks pass / the code has been formatted using Black
• Tests have been added to verify that the new code works

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.09%. Comparing base (2fd3586) to head (930eb02).
Report is 9 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #3974      +/-   ##
==========================================
+ Coverage   91.04%   91.09%   +0.05%     
==========================================
  Files         331      331              
  Lines       10698    10760      +62     
==========================================
+ Hits         9740     9802      +62     
  Misses        958      958              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[TheJulianJES]

Thanks for adding the tests. I think this looks pretty good already.

[TheJulianJES]

All these attributes should really be converted to the new zigpy AttributeDefs style. Search AttributeDefs in this repo or the zigpy repo for examples.
You don't have to do it in this PR, but it would be nice.

We can also access the name and id then: AqaraThermostatSpecificCluster.AttributeDefs.sensor_temp.name or .id.

[TheJulianJES]

This should be snake_case, so aqara_header.
Or maybe wrap_with_aqara_header? Something like that?

[TheJulianJES]

Is attrs intentionally set to {} again? It's already set at the beginning of the method. Depending on the order of the attributes parameter, the others wouldn't be written (although it's rare that this method gets multiple attributes to write at the same time).

If it's not intentional, this could be rewritten as:

attrs = {SENSOR_ATTR_NAME: self.aqara_header(0x12, params, 0x05) + params}

If not, well, the attrs = {} can be removed here.

[TheJulianJES]

I think it'd be nice to type this. Should be attrs: dict[str | int, Any] = {} then.

[TheJulianJES]

I believe you can just do params1 += bytes(12).

[TheJulianJES]

Here as well:
I believe you can just do params2 += bytes(12).

[TheJulianJES]

Technically, the attributes can either be the id or the name. Generally, it's the id, so this works, but it might be nice to accept both the id and name for SENSOR and SENSOR_TEMP.

If you were to implement the new-style AttributeDefs, you can use AqaraThermostatSpecificCluster.AttributeDefs.sensor_temp.name or AqaraThermostatSpecificCluster.AttributeDefs.sensor_temp.id to access name/id.

Or you can also use find_attribute to get the ZCLAttributeDef then. No need to check both id and name then. I think this should work then:

        attrs: dict[str | int, Any] = {}
        for attr, value in attributes.items():
            attr_def = self.find_attribute(attr)
            if attr_def == AqaraThermostatSpecificCluster.AttributeDefs.sensor_temp:
                # do stuff
            else:
                attrs[attr] = value
        return await super().write_attributes(attrs, manufacturer)

(This might be streamlined in zigpy in the future.)

[TheJulianJES]

I guess we don't need to call this every time here. Probably enough to just move it outside of the method.

[TheJulianJES]

So these need to be written in separate calls?

[TheJulianJES]

Thanks for noticing. Let's keep this in a separate PR though.
(Also, script/setup should also do this.)