Skip to content

Merge main into live #9724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 15, 2024
Merged

Merge main into live #9724

merged 3 commits into from
Mar 15, 2024

Conversation

dotnet-policy-service[bot]
Copy link
Contributor

Please don't squash-merge this PR.

@dotnet-issue-labeler dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 14, 2024
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit bb0b2d8:

✅ Validation status: passed

File Status Preview URL Details
xml/System/Type.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 41abdc1:

💡 Validation status: suggestions

File Status Preview URL Details
xml/System/Uri.xml 💡Suggestion View Details
xml/FrameworksIndex/net-9.0.xml ✅Succeeded
xml/FrameworksIndex/windowsdesktop-9.0.xml ✅Succeeded
xml/Microsoft.Extensions.Caching.Memory/CacheExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection/HttpClientFactoryServiceCollectionExtensions.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeNCryptHandle.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeNCryptKeyHandle.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeNCryptProviderHandle.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeNCryptSecretHandle.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeX509ChainHandle.xml ✅Succeeded View
xml/ns-System.Drawing.Imaging.Effects.xml ✅Succeeded View
xml/System.ComponentModel/CustomTypeDescriptor.xml ✅Succeeded View
xml/System.ComponentModel/DesignerAttribute.xml ✅Succeeded View
xml/System.ComponentModel/EditorAttribute.xml ✅Succeeded View
xml/System.ComponentModel/ICustomTypeDescriptor.xml ✅Succeeded View
xml/System.ComponentModel/PropertyDescriptor.xml ✅Succeeded View
xml/System.ComponentModel/TypeDescriptor.xml ✅Succeeded View
xml/System.Data.Common/DbConnectionStringBuilder.xml ✅Succeeded View
xml/System.Data.Common/DbDataRecord.xml ✅Succeeded View
xml/System.Data/DataRowView.xml ✅Succeeded View
xml/System.Diagnostics/StackTrace.xml ✅Succeeded View
xml/System.Drawing.Drawing2D/GraphicsPath.xml ✅Succeeded View
xml/System.Drawing.Imaging.Effects/BlackSaturationCurveEffect.xml ✅Succeeded View
xml/System.Drawing.Imaging.Effects/BlurEffect.xml ✅Succeeded View
xml/System.Drawing.Imaging.Effects/BrightnessContrastEffect.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.

xml/System/Uri.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:System#IFormattable#ToString(System.String,System.IFormatProvider) for uid: System.Uri.System#IFormattable#ToString(System.String,System.IFormatProvider).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:System#ISpanFormattable#TryFormat(System.Span{System.Char},System.Int32@,System.ReadOnlySpan{System.Char},System.IFormatProvider) for uid: System.Uri.System#ISpanFormattable#TryFormat(System.Span{System.Char},System.Int32@,System.ReadOnlySpan{System.Char},System.IFormatProvider).

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@jkotas @gewarren
Improve Assembly docs (#9679)
a7a3afa 
* Delete .NET Framework 1.0 note

No longer relevant

* Generalize description for BadImageFormatException

Delete explicit CLR 2.0 references

* Delete note about reflecting on C++ files

This problem become irrelevant with introduction of ASLR in Windows
Vista (2008)

* Move .NET Framework-specific content to be last

* Delete "The assembly is loaded into the application domain of the caller."

* More BadImageFormatException cleanup

* Delete more instance of "loaded into domain of the caller"

* Note that Assembly.Load creates assembly in isolated load context

* FB

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <[email protected]>

---------

Co-authored-by: Genevieve Warren <[email protected]>
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit a7a3afa:

💡 Validation status: suggestions

File Status Preview URL Details
xml/System/Uri.xml 💡Suggestion View Details
xml/FrameworksIndex/net-9.0.xml ✅Succeeded
xml/FrameworksIndex/windowsdesktop-9.0.xml ✅Succeeded
xml/Microsoft.Extensions.Caching.Memory/CacheExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection/HttpClientFactoryServiceCollectionExtensions.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeNCryptHandle.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeNCryptKeyHandle.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeNCryptProviderHandle.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeNCryptSecretHandle.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeX509ChainHandle.xml ✅Succeeded View
xml/ns-System.Drawing.Imaging.Effects.xml ✅Succeeded View
xml/System.ComponentModel/CustomTypeDescriptor.xml ✅Succeeded View
xml/System.ComponentModel/DesignerAttribute.xml ✅Succeeded View
xml/System.ComponentModel/EditorAttribute.xml ✅Succeeded View
xml/System.ComponentModel/ICustomTypeDescriptor.xml ✅Succeeded View
xml/System.ComponentModel/PropertyDescriptor.xml ✅Succeeded View
xml/System.ComponentModel/TypeDescriptor.xml ✅Succeeded View
xml/System.Data.Common/DbConnectionStringBuilder.xml ✅Succeeded View
xml/System.Data.Common/DbDataRecord.xml ✅Succeeded View
xml/System.Data/DataRowView.xml ✅Succeeded View
xml/System.Diagnostics/StackTrace.xml ✅Succeeded View
xml/System.Drawing.Drawing2D/GraphicsPath.xml ✅Succeeded View
xml/System.Drawing.Imaging.Effects/BlackSaturationCurveEffect.xml ✅Succeeded View
xml/System.Drawing.Imaging.Effects/BlurEffect.xml ✅Succeeded View
xml/System.Drawing.Imaging.Effects/BrightnessContrastEffect.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.

xml/System/Uri.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:System#IFormattable#ToString(System.String,System.IFormatProvider) for uid: System.Uri.System#IFormattable#ToString(System.String,System.IFormatProvider).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:System#ISpanFormattable#TryFormat(System.Span{System.Char},System.Int32@,System.ReadOnlySpan{System.Char},System.IFormatProvider) for uid: System.Uri.System#ISpanFormattable#TryFormat(System.Span{System.Char},System.Int32@,System.ReadOnlySpan{System.Char},System.IFormatProvider).

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@BillWagner BillWagner merged commit 1feeaea into live Mar 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BillWagner @gewarren @jkotas