-
Notifications
You must be signed in to change notification settings - Fork 710
Backport #10894: Add release notes for 3.14.2.0 release #10905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Cherry-pick of 7bd6198 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
There is something wrong with these conflicts, but they have to be fixed and the PR merged. Let's investigate! |
I think the changelogs are due to #10849 not being backported? —ETA: if so, the changes will have to be determined manually and reformatted as markdown. |
I guess, the changes to put in the changelog are already determined, so maybe the easiest way is to manually hack a passable .md formatting for the text that is already there? |
Well, I guess, the cabal-install/changelog is on the list:
|
@Mikolaj I pushed some obvious fixes around the main changelog files. I'm currently looking into the little changelog files. |
Okay, I pushed what looked like a plausible set of removals for the little changelog files (see the last commit). It'd be great if people could do some sanity checking around it. |
The list of removed changelog files agrees except for changelog.d/solver-api-change-fixup-3.14 that is not removed in the backport. Also, the extra entry that should not go into https://github.com/haskell/cabal/blob/master/cabal-install/ChangeLog.md got lost. |
it's not on
Sorry, can you provide some line that I can |
oh, scratch that, I got what line you're talking about |
@Mikolaj how about now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise looks okay on an admittedly quick pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you this looks fine. Indeed the 3.14.2 entry for hooks is mildly misleading, but it's also mildly clarifying, so I propose to let it be.
@mergify rebase |
(cherry picked from commit 7bd6198) # Conflicts: # Cabal-hooks/CHANGELOG.md # cabal-install/changelog # changelog.d/pr-10493 # changelog.d/pr-10546 # changelog.d/pr-10828.md
Co-authored-by: Artem Pelenitsyn <[email protected]> (cherry picked from commit 822997d)
…uring cherry-pick
✅ Branch has been successfully rebased |
f6c7e14
to
0d21e2a
Compare
Windows validate errored out with "failed to download https://www.stackage.org/lts-21.25/cabal.config : HTTP code 525" . Restarting. |
Add release notes for the 3.14.2.0 release
This is an automatic backport of pull request #10894 done by Mergify.