ENH: Improved testing of LTA handling - ITK-to-LTA, mri_concatenate_lta
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Best reviewed: commit by commit
Optimal code review plan
|
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
=========================================
+ Coverage 98.68% 98.89% +0.2%
=========================================
Files 11 11
Lines 992 992
Branches 129 129
=========================================
+ Hits 979 981 +2
+ Misses 7 6 -1
+ Partials 6 5 -1
Continue to review full report at Codecov.
|
oesteban
force-pushed
the
rf/more-lta-work
branch
2 times, most recently
from
3a9a132 to
065a1c9
Compare
oesteban
changed the title
mri_concatenate_ltamri_concatenate_lta
oesteban
force-pushed
the
rf/more-lta-work
branch
from
065a1c9 to
8b4857b
Compare
oesteban
force-pushed
the
rf/more-lta-work
branch
from
8b4857b to
ad25fb8
Compare
This PR adds more LTA and corresponding ITK conversions. The ITK conversions have been calculated with ``lta_convert``. The original NIfTI files have also been added to this PR for the implementation of future tests. Files have been named with some sort of BIDS derived nomenclature. Some provenance has been recorded as initial comments of the LTA files.
oesteban
force-pushed
the
rf/more-lta-work
branch
from
ad25fb8 to
e52389d
Compare
|
Good to go? |
oesteban
added a commit
to oesteban/nitransforms
that referenced
this pull request
Mar 28, 2020
This PR starts the implementation of "collapsing" series of transforms, for the linear case. It is tested on real data added in the context of nipy#66, nipy#74 and nipy#75. For the moment does not cover unintended use-cases such as collapsing transform sequences containing one or more nonlinear transforms. Resolves: nipy#88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more LTA and corresponding ITK conversions. The ITK
conversions have been calculated with
lta_convert. The originalNIfTI files have also been added to this PR for the implementation of
future tests.
Files have been named with some sort of BIDS derived nomenclature. Some
provenance has been recorded as initial comments of the LTA files.