ENH: Add an .asaffine() member to TransformChain
#90
+135
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR starts the implementation of "collapsing" series of transforms, for the linear case. It is tested on real data added in the context of nipy#66, nipy#74 and nipy#75. For the moment does not cover unintended use-cases such as collapsing transform sequences containing one or more nonlinear transforms. Resolves: nipy#88
|
Best reviewed: commit by commit
Optimal code review plan (1 warning)
|
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
==========================================
+ Coverage 98.96% 99.07% +0.11%
==========================================
Files 12 12
Lines 1059 1077 +18
Branches 135 138 +3
==========================================
+ Hits 1048 1067 +19
Misses 6 6
+ Partials 5 4 -1
Continue to review full report at Codecov.
|
|
Hello @oesteban! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-03-28 05:18:05 UTC |
oesteban
force-pushed
the
enh/88-collapse-linear-xfms
branch
from
0db6657 to
58e6ab8
Compare
oesteban
force-pushed
the
enh/88-collapse-linear-xfms
branch
from
58e6ab8 to
6afb6f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts the implementation of "collapsing" series of transforms,
for the linear case.
It is tested on real data added in the context of #66, #74 and #75.
For the moment does not cover unintended use-cases such as collapsing
transform sequences containing one or more nonlinear transforms.
Resolves: #88