ENH: Add FS transform regression #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Best reviewed: commit by commit
|
oesteban
approved these changes
Mar 19, 2020
|
Looks like we're not passing the freesurfer license into the Docker container? |
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
==========================================
+ Coverage 98.63% 98.63% +<.01%
==========================================
Files 11 11
Lines 950 951 +1
Branches 129 129
==========================================
+ Hits 937 938 +1
Misses 7 7
Partials 6 6
Continue to review full report at Codecov.
|
WDYM? |
The license - you had it only locally :D. Merging... |
This was referenced Mar 20, 2020
oesteban
added a commit
that referenced
this pull request
Mar 20, 2020
oesteban
added a commit
to oesteban/nitransforms
that referenced
this pull request
Mar 28, 2020
This PR starts the implementation of "collapsing" series of transforms, for the linear case. It is tested on real data added in the context of nipy#66, nipy#74 and nipy#75. For the moment does not cover unintended use-cases such as collapsing transform sequences containing one or more nonlinear transforms. Resolves: nipy#88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are passing locally, but a bit iffy on the results.