Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Inventory: forecast report #12218

Closed
wants to merge 1 commit into from

Conversation

jero-odoo
Copy link
Contributor

@jero-odoo jero-odoo commented Feb 27, 2025

@jero-odoo jero-odoo self-assigned this Feb 27, 2025
@robodoo
Copy link
Collaborator

robodoo commented Feb 27, 2025

Pull request status dashboard

@jero-odoo jero-odoo force-pushed the 18.0-inventory-forecast-report-jero branch 2 times, most recently from 5533d5c to 4d3ff3f Compare March 12, 2025 19:11
@jero-odoo jero-odoo marked this pull request as ready for review March 12, 2025 19:11
@C3POdoo C3POdoo requested a review from a team March 12, 2025 19:12
@jero-odoo
Copy link
Contributor Author

@larm-odoo this is ready for peer review. Thanks!

Copy link
Contributor

@larm-odoo larm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great doc @jero-odoo - I still can't believe we didn't have one! This was clear, which is a hard task since it is a confusing concept and report. I just had a few suggestions, and a couple questions (that's on me!) so when you check my comment,s this is ready for the next step.

@jero-odoo jero-odoo force-pushed the 18.0-inventory-forecast-report-jero branch from d508284 to 656ab1a Compare March 13, 2025 12:28
@jero-odoo jero-odoo requested a review from a team March 13, 2025 12:29
@jero-odoo
Copy link
Contributor Author

Thank you Lara!
@Felicious this is ready for final. Thank you!

Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful start @jero-odoo !

This is a great doc that gives a great overview of the forecasted report. Since it's a frequently used feature, I wanted to make sure 1-2 use cases that demonstrate how the report is meant to be used is also included.

Feel free to reach out to me if you need clarification on anything! 😊

@jero-odoo jero-odoo force-pushed the 18.0-inventory-forecast-report-jero branch from 656ab1a to e47f968 Compare March 14, 2025 18:46
@jero-odoo jero-odoo requested a review from Felicious March 14, 2025 18:50
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great use cases, @jero-odoo!

Proud of how much you've shown to understand inventory and this reporting feature. 😊

Approving, with a request to add another use case. It'll help capture the remaining feedback from the SME

@jero-odoo jero-odoo force-pushed the 18.0-inventory-forecast-report-jero branch from e47f968 to 456b2c3 Compare March 14, 2025 19:20
@jero-odoo jero-odoo requested a review from a team March 14, 2025 19:29
@jero-odoo
Copy link
Contributor Author

@samueljlieber this is ready for tech review. Thanks!

Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

improving the impact of reporting (:

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jero-odoo, great job on this PR! Your changes look good to me, minus one missing a closing backtick in the Replenish products section. Please take a look at Fel's last few comments too before merge!

Thank you for your work!
.....
@robodoo delegate=jero-odoo

Co-authored-by: larm-odoo <[email protected]>

Co-authored-by: Felicia Kuan <[email protected]>
@jero-odoo jero-odoo force-pushed the 18.0-inventory-forecast-report-jero branch from a1accfd to 1c81731 Compare March 14, 2025 20:07
@jero-odoo
Copy link
Contributor Author

Thank you!!

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants