Rails 6 support #690
Merged
Rails 6 support #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
…tive_comparison` Follow up to rails/rails@eb5fef5.
Adapt to changed method signature in Rails 6.0.
Remove SQLite versioning Set to use Rails 6.0.0
Update version to Rails 6.0.0
Rails 6: Fix for translate_exception method signature
|
Hey @wpolicarpo Do you need help with this PR? Let me know how I can help. Cheers, |
|
@robikovacs any help is welcome here, yes. We have @aidanharan currently working on having all the tests passing and some other initiatives already started as PRs. Maybe we can build a list of failing tests and tackle them one by one (or by groups if it's more relevant). |
Rails 6: Correctly retrieve Arel::Table in join queries
…idden-attributes Rails 6: Sanitize forbidden attributes for exists relation
Method should be public
Rails 6: Cache database version in schema cache
Rails 6: Coerce tests as SQL Server does not return string value for updated_at
* Coerce test as time has default precision * Fixed typo
* Support lazy transactions * aaded materialize_transactions guard to connection uses. for implementing supports for lazy transactions rails/rails#32647 (comment) * Moved materialize_transactions calls * Fix typo * Materialize transaction in do_execute Co-authored-by: Yehuda Goldberg <[email protected]>
…#788) The transaction in the test become SavepointTransaction because tests automatically wrapped in transaction, and SQL Server does not have query for release_savepoint
* add database_exists? rails/rails#36471 * fix translate error to ActiveRecord::NoDatabaseError in connection creating add "test bad connection" like other adapters
* Use same sqlite3 and pg versions as Rails 6.0.2.2 * Bump to version used by CI * Revert version
* Coerce test to managable number of records * Assert that unprepared statement being used * Updated test * Fix test
* Coerce and call original * Added comment
Rails 6: Fix randomly failing tests by loading models schema
Rails 6: Fix coerced predicate builder tests
Rails 6: Workaround for randomly failing schema test
Rails 6: Remove invalid order from FROM subquery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP pull request to bring Rails 6 changes to SQL Server adapter.
O lot of people asked how they can help and what are the failing tests we should fix to have a stable version. Best thing to do is to check the latest Travis build for this branch, see what is failing and then open a PR for this branch.