6 0 dev #731
6 0 dev #731
Conversation
187870db2fcc58aa0da8bb3f26711664fd5ed611 kamipo:remove_arel_nodes_values
NoMethodError: undefined method `split' for nil:NilClass in tests
|
down to 45 errors 55 fails in active record tests and 0 fails 0 errors in sqladapter |
|
May want to NOT include the testing - b4f558e commit. It assigns He provided a patch to my PR that changed the altered code back. |
|
@dglaser I was just reviewing these changes, and it looks like a future commit does indeed fix that issue. At the end of this changeset, it includes assignment with This looks like great progress! |
|
|
could do yeah, though official tinytds also needs to be updated a bit for ruby 2.7, and it results in one less error too. The rest sure, just wanted up to date images to test |
|
I was only throwing in my 2 cents. As a user, I appreciate wanting an up-to-date image. Maybe the source could be a git repo here for us to submit PR's to and the "owners" to deploy to rails-sqlserver hub?? |
…nitest-calls Fix minitest expectation deprecation warnings
…n-tests Calculate should not remove ordering for MSSQL
…tinct-select-exists Order by selected items when using distinct exists
…ult-precision Use default precision for 'time' column type
…nt-cache-tests Adapter does not use prepared statement cache
…ult-precision-refactor Set default time precision when registering time type
Use method from Rails master
…ns-tests Quoted table names containing square brackets need to be regex escaped
|
The tests on We should get the adapter working against Rails 6.0.0 before moving onto higher releases so that older releases can be supported. @nemesit: Would you be able to merge the latest changes into your |
…erver-adapter into 6-0-dev * 'master' of github.com:rails-sqlserver/activerecord-sqlserver-adapter: Quoted table names containing square brackets need to be regex escaped Adapter does not use prepared statement cache Set default time precision when registering time type Default precision for 'time' column type is 7 Order by selected items when using distinct exists Calculate should not remove ordering for MSSQL Fix minitest expection calls Prepare for Minitest6 Use rails backtrace in tests # Conflicts: # test/cases/column_test_sqlserver.rb # test/cases/rake_test_sqlserver.rb # test/cases/showplan_test_sqlserver.rb # test/cases/specific_schema_test_sqlserver.rb # test/cases/transaction_test_sqlserver.rb
|
done |
|
Maybe its a rebase that needed as there are still conflicting files and on the 'Files Changes' tab you see changes that are already in the In general, I think it would be better if the fixes in this PR were broken into separate PRs describing what they are fixing. This PR contains a mixture of bug fixes, docker image changes, Gemfile changes, etc. It is better to have PRs where just one issue is just being discussed. I just did that with #748 |
|
@nemesit do you mind rebasing your branch? I have pushed new Docker images for all newer rubies now and moved them to a new |
|
Closing this in favor of #690. |
No description provided.