Adding "backtrace off" option for fuchsia targets #101559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-libs
|
r? @m-ou-se (rust-highfive has picked a reviewer for you, use r? to override) |
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
rust-highfive
added
the
S-waiting-on-review
|
r? @tmandry |
andrewpollack
force-pushed
the
add-backtrace-off-fuchsia
branch
from
b9dcdb6 to
0a41021
Compare
tmandry
reviewed
Sep 8, 2022
library/std/src/panic.rs
Outdated
| @@ -296,9 +296,12 @@ pub fn get_backtrace_style() -> Option<BacktraceStyle> { | |||
| } | |||
|
|
|||
| // Setting environment variables for Fuchsia components isn't a standard | |||
| // or easily supported workflow. For now, display backtraces by default. | |||
| // or easily supported workflow. For now, display backtraces by default, | |||
| // and allow turning off completely for compiler tests. | |||
There was a problem hiding this comment.
Suggested change
| // and allow turning off completely for compiler tests. | |
| // and allow turning off completely. |
Compiler tests motivated this PR but it's a generally useful feature.
andrewpollack
force-pushed
the
add-backtrace-off-fuchsia
branch
from
0a41021 to
6260aa5
Compare
tmandry
reviewed
Sep 14, 2022
|
@bors delegate+ rollup |
|
✌️ @andrewpollack can now approve this pull request |
andrewpollack
force-pushed
the
add-backtrace-off-fuchsia
branch
from
6260aa5 to
88baf8f
Compare
|
@bors r=tmandry |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 15, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#100415 (Add BE8 support) - rust-lang#101559 (Adding "backtrace off" option for fuchsia targets) - rust-lang#101740 (Adding ignore-fuchsia arg to non-applicable compiler ui tests) - rust-lang#101778 (rustdoc: clean up DOM by removing `.dockblock-short p`) - rust-lang#101786 (Tidy will not check coding style in bootstrap/target) - rust-lang#101810 (Constify `PartialEq` for `Ordering`) - rust-lang#101812 (rustdoc: clean up CSS `#titles` using flexbox) - rust-lang#101820 (rustdoc: remove no-op rule `a { background: transparent }`) - rust-lang#101828 (Add test for rust-lang#101743) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used for improving compiler test suite results on Fuchsia targets