Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy will not check coding style in bootstrap/target #101786

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

chenyukang
Copy link
Member

bootstrap/target may contains the files generated by rust-analysis, which we won't want to be checked.

@rust-highfive
Copy link
Collaborator

r? @jyn514

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 14, 2022
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good :) can you also add it to .gitignore at the top level?

@jyn514 jyn514 added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. A-meta Area: Issues & PRs about the rust-lang/rust repository itself and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2022
@chenyukang chenyukang force-pushed the fix-tidy-for-bootstrap branch from 32d6b2e to 31d5348 Compare September 14, 2022 06:45
@chenyukang
Copy link
Member Author

This seems good :) can you also add it to .gitignore at the top level?

It's already in .gitignore.

@jyn514
Copy link
Member

jyn514 commented Sep 14, 2022

@bors r+ rollup

At some point we should sync these ignored files with .gitignore, but that shouldn't block your PR.

@bors
Copy link
Contributor

bors commented Sep 14, 2022

📌 Commit 31d5348 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 14, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 15, 2022
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#100415 (Add BE8 support)
 - rust-lang#101559 (Adding "backtrace off" option for fuchsia targets)
 - rust-lang#101740 (Adding ignore-fuchsia arg to non-applicable compiler ui tests)
 - rust-lang#101778 (rustdoc: clean up DOM by removing `.dockblock-short p`)
 - rust-lang#101786 (Tidy will not check coding style in bootstrap/target)
 - rust-lang#101810 (Constify `PartialEq` for `Ordering`)
 - rust-lang#101812 (rustdoc: clean up CSS `#titles` using flexbox)
 - rust-lang#101820 (rustdoc: remove no-op rule `a { background: transparent }`)
 - rust-lang#101828 (Add test for rust-lang#101743)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a88b96b into rust-lang:master Sep 15, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants