Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: clean up DOM by removing .dockblock-short p #101778

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

notriddle
Copy link
Contributor

@notriddle notriddle commented Sep 13, 2022

On https://doc.rust-lang.org/nightly/std/ this reduces the number out of document.querySelectorAll("*").length from 1278 to 1103.

Preview: https://notriddle.com/notriddle-rustdoc-test/docblock-short-p/std/index.html

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Sep 13, 2022
@rust-highfive
Copy link
Collaborator

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Sep 13, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 13, 2022
@notriddle notriddle force-pushed the notriddle/docblock-short-p branch from 034b8fb to 781cd21 Compare September 13, 2022 21:31
@notriddle notriddle changed the title rustdoc: clean up DOM by removing .dockblock p rustdoc: clean up DOM by removing .dockblock-short p Sep 13, 2022
@notriddle notriddle force-pushed the notriddle/docblock-short-p branch from 781cd21 to 10a71c9 Compare September 13, 2022 22:22
On https://doc.rust-lang.org/nightly/std/ this reduces the number out of
`document.querySelectorAll("*").length` from 1278 to 1103.
@notriddle notriddle force-pushed the notriddle/docblock-short-p branch from 10a71c9 to 11a52dc Compare September 13, 2022 23:03
@GuillaumeGomez
Copy link
Member

Nice!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 14, 2022

📌 Commit 11a52dc has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 15, 2022
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#100415 (Add BE8 support)
 - rust-lang#101559 (Adding "backtrace off" option for fuchsia targets)
 - rust-lang#101740 (Adding ignore-fuchsia arg to non-applicable compiler ui tests)
 - rust-lang#101778 (rustdoc: clean up DOM by removing `.dockblock-short p`)
 - rust-lang#101786 (Tidy will not check coding style in bootstrap/target)
 - rust-lang#101810 (Constify `PartialEq` for `Ordering`)
 - rust-lang#101812 (rustdoc: clean up CSS `#titles` using flexbox)
 - rust-lang#101820 (rustdoc: remove no-op rule `a { background: transparent }`)
 - rust-lang#101828 (Add test for rust-lang#101743)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9449848 into rust-lang:master Sep 15, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 15, 2022
@notriddle notriddle deleted the notriddle/docblock-short-p branch September 15, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants