Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sphinxcontrib-htmlhelp 2.1.0 #39680

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

sphinxcontrib-htmlhelp 2.1.0 #39680

wants to merge 1 commit into from

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented Mar 12, 2025

urgently needed for python 3.13 support.
See https://groups.google.com/g/sage-devel/c/lr03GlRBr9g/m/M8nTdw_5AQAJ

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@dimpase
Copy link
Member Author

dimpase commented Mar 12, 2025

@jhpalmieri

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 625bad0; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@jhpalmieri
Copy link
Member

LGTM

@jhpalmieri
Copy link
Member

Marking as a blocker since without it, parallel processing is broken.

@dimpase
Copy link
Member Author

dimpase commented Mar 12, 2025

some CI failures are not relevant to this PR.
E.g. in conda/meson CI I see 1 test failure:

sage -t --warn-long 5.0 --random-seed=108243029651382096890610016925449693746 src/sage/misc/weak_dict.pyx # 1 doctest failed

@jhpalmieri jhpalmieri mentioned this pull request Mar 12, 2025
Open
5 tasks
@jhpalmieri
Copy link
Member

Let me use this opportunity to advertise #38116. Without the fix here, since Sage was not correctly detecting the number of cores to use, make ptestlong was actually succeeding on OS X. With the fix here, make ptestlong went back to its old behavior of failing on a few files in sage/doctest/, as described at #38116. It would be nice to fix that, but I don't know how.

@kiwifb kiwifb mentioned this pull request Mar 18, 2025
Open
2 tasks
vbraun pushed a commit to vbraun/sage that referenced this pull request Mar 19, 2025
f0ee8d2 
sagemathgh-39680: sphinxcontrib-htmlhelp 2.1.0
    
urgently needed for python 3.13 support.
See https://groups.google.com/g/sage-devel/c/lr03GlRBr9g/m/M8nTdw_5AQAJ

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39680
Reported by: Dima Pasechnik
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request Mar 19, 2025
3012e84 
sagemathgh-39686: update sphinxcontrib packages
    
This is a follow up to sagemath#39577 where sphinx was update but not the
sphinxcontrib packages.
This causes breakages for some users.



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

sagemath#39680 deals with one the packages that would be covered by this PR
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39686
Reported by: François Bissey
Reviewer(s):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: packages: standard p: blocker / 1 s: positive review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimpase @jhpalmieri