Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sphinxcontrib packages #39686

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

kiwifb
Copy link
Member

@kiwifb kiwifb commented Mar 12, 2025

This is a follow up to #39577 where sphinx was update but not the sphinxcontrib packages.
This causes breakages for some users.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

#39680 deals with one the packages that would be covered by this PR

@jhpalmieri
Copy link
Member

sphinxcontrib-htmlhelp is taken care of on #39680. Would you mind making that a dependency and delete that upgrade here?

@kiwifb
Copy link
Member Author

kiwifb commented Mar 12, 2025

I guess I can do that. When I have a bit of free time later today.

Copy link

github-actions bot commented Mar 12, 2025

Documentation preview for this PR (built with commit 02c7216; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@kiwifb
Copy link
Member Author

kiwifb commented Mar 12, 2025

there is already a positively reviewed by @jhpalmieri PR which does this version bump!

This PR does more than just the one package. I will update to take into account your PR.

@kiwifb
Copy link
Member Author

kiwifb commented Mar 12, 2025

PR updated.

@jhpalmieri
Copy link
Member

PR updated.

Thanks very much!

@jhpalmieri
Copy link
Member

Looks good, thank you.

vbraun pushed a commit to vbraun/sage that referenced this pull request Mar 19, 2025
sagemathgh-39686: update sphinxcontrib packages
    
This is a follow up to sagemath#39577 where sphinx was update but not the
sphinxcontrib packages.
This causes breakages for some users.



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

sagemath#39680 deals with one the packages that would be covered by this PR
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39686
Reported by: François Bissey
Reviewer(s):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants