-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates marvin for DR17 with VACs #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating marvin and datamodels for dr17
…o vac_gz Update from vacs_dr17
Changed galaxyzoo.py for DR17
updating Vac mvm (visual_morphology script)
Finished adding doc strings to all helper functions defined before the main class.
Add the last of the doc strings for the plotting methods of the mian class.
This notebook shows how to use the GZ3D custom class to make various plots.
One of the class methods was a hold over from old code and is no longer needed.
[WIP] Add GZ3D vac code
Karen has gone through and cleaned up some of the explanations and added a few links in places. As part of this update we also fixed a bug in the `polar_plot` code where labels were not being used in the scatter plot calls. The examples in the notebook now explicitly create figure legends to ensure this is working as expected.
Added a reference link for azimuthal angle.
Update GZ3D tutorial notebook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates marvin for DR17