Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates marvin for DR17 with VACs #747

Merged
merged 73 commits into from
Nov 22, 2021
Merged

Updates marvin for DR17 with VACs #747

merged 73 commits into from
Nov 22, 2021

Conversation

havok2063
Copy link
Collaborator

@havok2063 havok2063 commented Nov 19, 2021

This PR updates marvin for DR17

  • updated VACs: gema, HI, galaxy_zoo, firefly, visual_morphology
  • new VACs: galaxy_zoo_3d
  • updates to documentation
  • updates to the web - various tooltips
  • pins the requirements to the next major version

tobiasgeron and others added 30 commits July 2, 2021 14:34
updating marvin and datamodels for dr17
Changed galaxyzoo.py for DR17
updating Vac mvm (visual_morphology script)
CKrawczyk and others added 22 commits November 15, 2021 14:26
Finished adding doc strings to all helper functions defined before the main class.
Add the last of the doc strings for the plotting methods of the mian class.
This notebook shows how to use the GZ3D custom class to make various plots.
One of the class methods was a hold over from old code and is no longer needed.
Karen has gone through and cleaned up some of the explanations and added a few links in places.

As part of this update we also fixed a bug in the `polar_plot` code where labels were not being used in the scatter plot calls.  The examples in the notebook now explicitly create figure legends to ensure this is working as expected.
Added a reference link for azimuthal angle.
@havok2063 havok2063 added the enhancement indicates a new feature or functionality to be added label Nov 19, 2021
@havok2063 havok2063 self-assigned this Nov 19, 2021
@havok2063 havok2063 merged commit 19d6e16 into master Nov 22, 2021
@havok2063 havok2063 deleted the vacs_dr17 branch December 7, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement indicates a new feature or functionality to be added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants