Create hasTokenCounter attribute to assessment_config #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichDom2185
reviewed
Feb 12, 2024
There was a problem hiding this comment.
I understand that the other columns are also defined the same way (non-null, but optional) – this may or may not have been an error, let me get back to you after I check with the original implementers.
Please remind me if I don't get back to you after a couple days.
Thanks for working on this!
|
Oh, I realised some tests are failing, could you fix them as well? We try to keep the coverage ≥ 95%. Thanks! |
|
Corresponding frontend PR: source-academy/frontend#2775 |
6 tasks
sayomaki
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create hasTokenCounter attribute to assessment_config