Add Token Counter Displayer in Repl #2775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayjay19630
force-pushed
the
ReplNotificationDisplayer
branch
from
b5944f4 to
32d9e1d
Compare
Pull Request Test Coverage Report for Build 7889640712Details
💛 - Coveralls |
2 tasks
|
Corresponding backend PR: source-academy/backend#1062 |
RichDom2185
reviewed
Feb 13, 2024
| type: 'notification' | ||
| }); | ||
| } | ||
| const customNotification = state[workspaceLocation].customNotification; |
There was a problem hiding this comment.
Is this for future plans, or already used?
There was a problem hiding this comment.
This is most likely for future plans. Not yet used.
There was a problem hiding this comment.
Would it make more sense for customNotification to be customNotifications (a string[]) instead then? Since it's reasonable to assume you can have either 0, 1, or more than 1; there's no reason to only have either 0 or 1 notification present.
Anyway, it's not used now, so I'll just approve the PR, but perhaps you can create an issue: either remove it (cause it's unused), or make it support multiple notifications?
RichDom2185
approved these changes
Feb 13, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Token Counter Displayer in Repl
Description:
This pull request creates a new assessment config which enables a token counter. This token counter is a notification which lets the user know how many tokens their program has. This notification can be seen as an output in the Repl once the program is run.
Tasks:
Notes:
Note that modifying custom Repl notifications hasn't been implemented yet (possible future updates).
Co-authored-by: Lau Xiang Yu